cleaned up rankdocsretrieverbuilder

Author: mridula-s109

server/src/main/java/org/elasticsearch/search/retriever/RankDocsRetrieverBuilder.java

@@ -105,13 +105,12 @@ public void extractToSearchSourceBuilder(SearchSourceBuilder searchSourceBuilder
         // if we have aggregations we need to compute them based on all doc matches, not just the top hits
         // similarly, for profile and explain we re-run all parent queries to get all needed information
         RankDoc[] rankDocResults = rankDocs.get();
-        // If minScore is applied, total hits should only count the docs >= minScore, even if track_total_hits is requested.
-        boolean trackTotalHitsDespiteMinScore = (hasAggregations(searchSourceBuilder)
+        float effectiveMinScore = this.minScore() != null ? this.minScore() : RankDocsQueryBuilder.DEFAULT_MIN_SCORE;
+
+        if (hasAggregations(searchSourceBuilder)
             || isExplainRequest(searchSourceBuilder)
             || isProfileRequest(searchSourceBuilder)
-            || shouldTrackTotalHits(searchSourceBuilder)) && (sourceHasMinScore() == false);
-
-        if (trackTotalHitsDespiteMinScore) {
+            || shouldTrackTotalHits(searchSourceBuilder)) {
             if (false == isExplainRequest(searchSourceBuilder)) {
                 rankQuery = new RankDocsQueryBuilder(
                     rankDocResults,
@@ -127,7 +126,6 @@ public void extractToSearchSourceBuilder(SearchSourceBuilder searchSourceBuilder
             }
         } else {
             // Pass minScore down to RankDocsQueryBuilder
-            float effectiveMinScore = this.minScore() != null ? this.minScore() : RankDocsQueryBuilder.DEFAULT_MIN_SCORE;
             rankQuery = new RankDocsQueryBuilder(rankDocResults, null, false, effectiveMinScore);
         }
         rankQuery.queryName(retrieverName());