Skip to content

Commit d71bf2c

Browse files
fix unit tests
1 parent 71eac8d commit d71bf2c

File tree

3 files changed

+10
-7
lines changed

3 files changed

+10
-7
lines changed

x-pack/plugin/inference/src/test/java/org/elasticsearch/index/query/SemanticKnnVectorQueryRewriteInterceptorTests.java

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -65,7 +65,7 @@ public void testKnnQueryWithVectorBuilderIsInterceptedAndRewritten() throws IOEx
6565
}
6666

6767
public void testKnnQueryWithVectorBuilderIsInterceptedAndRewrittenWithBoostAndQueryName() throws IOException {
68-
float BOOST = 2.0f;
68+
float BOOST = 5.0f;
6969
String QUERY_NAME = "knn_query";
7070

7171
Map<String, InferenceFieldMetadata> inferenceFields = Map.of(
@@ -81,10 +81,12 @@ public void testKnnQueryWithVectorBuilderIsInterceptedAndRewrittenWithBoostAndQu
8181
testRewrittenInferenceQuery(context, original);
8282
QueryBuilder rewritten = original.rewrite(context);
8383
InterceptedQueryBuilderWrapper intercepted = (InterceptedQueryBuilderWrapper) rewritten;
84+
assertEquals(BOOST, intercepted.boost(), 0.0f);
85+
assertEquals(QUERY_NAME, intercepted.queryName());
8486
NestedQueryBuilder nestedQueryBuilder = (NestedQueryBuilder) intercepted.queryBuilder;
8587
KnnVectorQueryBuilder knnVectorQueryBuilder = (KnnVectorQueryBuilder) nestedQueryBuilder.query();
86-
assertEquals(BOOST, knnVectorQueryBuilder.boost(), 0.0f);
87-
assertEquals(QUERY_NAME, knnVectorQueryBuilder.queryName());
88+
assertEquals(BOOST, knnVectorQueryBuilder.boost(), 5.0f);
89+
assertNull(knnVectorQueryBuilder.queryName());
8890
}
8991

9092
public void testKnnWithQueryBuilderWithoutInferenceIdIsInterceptedAndRewritten() throws IOException {

x-pack/plugin/inference/src/test/java/org/elasticsearch/index/query/SemanticMatchQueryRewriteInterceptorTests.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,7 @@ public class SemanticMatchQueryRewriteInterceptorTests extends ESTestCase {
3737
private static final String FIELD_NAME = "fieldName";
3838
private static final String VALUE = "value";
3939
private static final String QUERY_NAME = "match_query";
40-
private static final float BOOST = 2.0f;
40+
private static final float BOOST = 5.0f;
4141

4242
@Before
4343
public void setup() {

x-pack/plugin/inference/src/test/java/org/elasticsearch/index/query/SemanticSparseVectorQueryRewriteInterceptorTests.java

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -111,7 +111,7 @@ public void testSparseVectorQueryOnNonInferenceFieldRemainsUnchanged() throws IO
111111
}
112112

113113
public void testBoostAndQueryNameOnSparseVectorQueryRewrite() throws IOException {
114-
float BOOST = 2.0f;
114+
float BOOST = 5.0f;
115115
String QUERY_NAME = "sparse_vector_query";
116116

117117
Map<String, InferenceFieldMetadata> inferenceFields = Map.of(
@@ -128,7 +128,7 @@ public void testBoostAndQueryNameOnSparseVectorQueryRewrite() throws IOException
128128
rewritten instanceof InterceptedQueryBuilderWrapper
129129
);
130130
InterceptedQueryBuilderWrapper intercepted = (InterceptedQueryBuilderWrapper) rewritten;
131-
assertEquals(BOOST, intercepted.boost(), 1.0f);
131+
assertEquals(BOOST, intercepted.boost(), 0.0f);
132132
assertEquals(QUERY_NAME, intercepted.queryName());
133133
assertTrue(intercepted.queryBuilder instanceof NestedQueryBuilder);
134134
NestedQueryBuilder nestedQueryBuilder = (NestedQueryBuilder) intercepted.queryBuilder;
@@ -139,7 +139,8 @@ public void testBoostAndQueryNameOnSparseVectorQueryRewrite() throws IOException
139139
assertEquals(SemanticTextField.getEmbeddingsFieldName(FIELD_NAME), sparseVectorQueryBuilder.getFieldName());
140140
assertEquals(INFERENCE_ID, sparseVectorQueryBuilder.getInferenceId());
141141
assertEquals(QUERY, sparseVectorQueryBuilder.getQuery());
142-
assertEquals(BOOST, sparseVectorQueryBuilder.boost(), 1.0f);
142+
assertEquals(BOOST, sparseVectorQueryBuilder.boost(), 5.0f);
143+
assertNull(sparseVectorQueryBuilder.queryName());
143144
}
144145

145146
private QueryRewriteContext createQueryRewriteContext(Map<String, InferenceFieldMetadata> inferenceFields) {

0 commit comments

Comments
 (0)