Skip to content

Commit d721afe

Browse files
Implement review suggestions
1 parent fa32461 commit d721afe

File tree

2 files changed

+3
-1
lines changed

2 files changed

+3
-1
lines changed

x-pack/plugin/esql/qa/server/src/main/java/org/elasticsearch/xpack/esql/qa/rest/generative/EsqlQueryGenerator.java

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -527,6 +527,8 @@ private static String constantExpression() {
527527
}
528528

529529
private static String randomIdentifier() {
530+
// Let's create identifiers that are long enough to avoid collisions with reserved keywords.
531+
// There could be a smarter way (introspection on the lexer class?), but probably it's not worth the effort
530532
return randomAlphaOfLength(randomIntBetween(8, 12));
531533
}
532534

x-pack/plugin/esql/qa/testFixtures/src/main/java/org/elasticsearch/xpack/esql/CsvTestsDataLoader.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -315,7 +315,7 @@ private static boolean isLookupDataset(TestDataset dataset) throws IOException {
315315
return (mode != null && mode.equalsIgnoreCase("lookup"));
316316
}
317317

318-
public static boolean isSourceMappingDataset(TestDataset dataset) throws IOException {
318+
private static boolean isSourceMappingDataset(TestDataset dataset) throws IOException {
319319
if (dataset.mappingFileName() == null) {
320320
return true;
321321
}

0 commit comments

Comments
 (0)