cr feedback

Author: svilen-mihaylov-elastic

docs/reference/query-languages/esql/_snippets/functions/description/v_hamming.md

@@ -13,17 +13,17 @@
  ;
 
 // tag::vector-hamming-result[]
-color:text  | similarity:double
-cyan        | 1.0
-azure       | 0.8333333134651184
-blue        | 0.6666666865348816
-honeydew    | 0.6666666865348816
-lime        | 0.6666666865348816
-mint cream  | 0.6666666865348816
-white       | 0.6666666865348816
-thistle     | 0.625
-lavender    | 0.5833333134651184
-aqua marine | 0.5416666865348816
+color:text | similarity:double
+red        | 24.0
+orange     | 20.0
+gold       | 18.0
+indigo     | 18.0
+bisque     | 17.0
+maroon     | 17.0
+pink       | 17.0
+salmon     | 17.0
+black      | 16.0
+firebrick  | 16.0
 // end::vector-hamming-result[] 
 ;
 
@@ -37,17 +37,17 @@ from colors
 | keep color, score
 ;
 
-color:text  | score:double
-cyan        | 1.5
-azure       | 1.417
-blue        | 1.333
-honeydew    | 1.333
-lime        | 1.333
-mint cream  | 1.333
-white       | 1.333
-thistle     | 1.313
-lavender    | 1.292
-aqua marine | 1.271
+color:text | score:double
+red        | 13.0
+orange     | 11.0
+gold       | 10.0
+indigo     | 10.0
+bisque     | 9.5
+maroon     | 9.5
+pink       | 9.5
+salmon     | 9.5
+black      | 9.0
+firebrick  | 9.0
 ;
 
 similarityWithLiteralVectors
@@ -59,7 +59,7 @@ row a = 1
 ;
 
 similarity:double
-0.833
+4.0
 ;
 
 similarityWithStats
@@ -71,7 +71,7 @@ from colors
 ;
 
 avg:double | min:double | max:double
-0.445      | 0.0        | 1.0
+13.322     | 0.0        | 24.0
 ;
 
 similarityWithNull

docs/reference/query-languages/esql/_snippets/functions/examples/v_hamming.md

@@ -39,12 +39,12 @@ public Hamming(
         @Param(
             name = "left",
             type = { "dense_vector" },
-            description = "first dense_vector to calculate hamming distance between"
+            description = "First dense_vector to use to calculate the Hamming distance"
         ) Expression left,
         @Param(
             name = "right",
             type = { "dense_vector" },
-            description = "second dense_vector to calculate hamming distance between"
+            description = "Second dense_vector to use to calculate the Hamming distance"
         ) Expression right
     ) {
         super(source, left, right);
@@ -83,6 +83,6 @@ public static float calculateSimilarity(float[] leftScratch, float[] rightScratc
         for (int i = 0; i < leftScratch.length; i++) {
             b[i] = (byte) rightScratch[i];
         }
-        return ((a.length * Byte.SIZE) - VectorUtil.xorBitCount(a, b)) / (float) (a.length * Byte.SIZE);
+        return VectorUtil.xorBitCount(a, b);
     }
 }