Fix compilation

Author: n1v0lg

x-pack/plugin/core/src/main/java/org/elasticsearch/xpack/core/security/authz/permission/Role.java

@@ -256,6 +256,17 @@ public Builder add(IndexPrivilege privilege, String... indices) {
             return this;
         }
 
+        // TODO remove me
+        public Builder add(
+            FieldPermissions fieldPermissions,
+            Set<BytesReference> query,
+            IndexPrivilege privilege,
+            boolean allowRestrictedIndices,
+            String... indices
+        ) {
+            return add(fieldPermissions, query, privilege, allowRestrictedIndices, false, indices);
+        }
+
         public Builder add(
             FieldPermissions fieldPermissions,
             Set<BytesReference> query,

x-pack/plugin/security/src/test/java/org/elasticsearch/xpack/security/authz/AuthorizedIndicesTests.java

@@ -188,7 +188,7 @@ public void testSecurityIndicesAreRestrictedForDefaultRole() {
 
     public void testSecurityIndicesAreNotRemovedFromUnrestrictedRole() {
         Role role = Role.builder(RESTRICTED_INDICES, randomAlphaOfLength(8))
-            .add(FieldPermissions.DEFAULT, null, IndexPrivilege.ALL, true, "*")
+            .add(FieldPermissions.DEFAULT, null, IndexPrivilege.ALL, true, false, "*")
             .cluster(Set.of("all"), Set.of())
             .build();
         Settings indexSettings = Settings.builder().put(IndexMetadata.SETTING_VERSION_CREATED, IndexVersion.current()).build();

x-pack/plugin/security/src/test/java/org/elasticsearch/xpack/security/authz/RBACEngineTests.java

@@ -781,7 +781,7 @@ public void testCheckRestrictedIndexPatternPermission() throws Exception {
             randomIntBetween(2, XPackPlugin.ASYNC_RESULTS_INDEX.length() - 2)
         );
         Role role = Role.builder(RESTRICTED_INDICES, "role")
-            .add(FieldPermissions.DEFAULT, null, IndexPrivilege.INDEX, false, patternPrefix + "*")
+            .add(FieldPermissions.DEFAULT, null, IndexPrivilege.INDEX, false, false, patternPrefix + "*")
             .build();
         RBACAuthorizationInfo authzInfo = new RBACAuthorizationInfo(role, null);
 
@@ -892,7 +892,7 @@ public void testCheckRestrictedIndexPatternPermission() throws Exception {
         );
 
         role = Role.builder(RESTRICTED_INDICES, "role")
-            .add(FieldPermissions.DEFAULT, null, IndexPrivilege.INDEX, true, patternPrefix + "*")
+            .add(FieldPermissions.DEFAULT, null, IndexPrivilege.INDEX, true, false, patternPrefix + "*")
             .build();
         authzInfo = new RBACAuthorizationInfo(role, null);
         response = hasPrivileges(
@@ -917,8 +917,8 @@ public void testCheckExplicitRestrictedIndexPermissions() throws Exception {
         final boolean restrictedIndexPermission = randomBoolean();
         final boolean restrictedMonitorPermission = randomBoolean();
         Role role = Role.builder(RESTRICTED_INDICES, "role")
-            .add(FieldPermissions.DEFAULT, null, IndexPrivilege.INDEX, restrictedIndexPermission, ".sec*")
-            .add(FieldPermissions.DEFAULT, null, IndexPrivilege.MONITOR, restrictedMonitorPermission, ".security*")
+            .add(FieldPermissions.DEFAULT, null, IndexPrivilege.INDEX, restrictedIndexPermission, false, ".sec*")
+            .add(FieldPermissions.DEFAULT, null, IndexPrivilege.MONITOR, restrictedMonitorPermission, false, ".security*")
             .build();
         RBACAuthorizationInfo authzInfo = new RBACAuthorizationInfo(role, null);
 
@@ -975,8 +975,8 @@ public void testCheckExplicitRestrictedIndexPermissions() throws Exception {
 
     public void testCheckRestrictedIndexWildcardPermissions() throws Exception {
         Role role = Role.builder(RESTRICTED_INDICES, "role")
-            .add(FieldPermissions.DEFAULT, null, IndexPrivilege.INDEX, false, ".sec*")
-            .add(FieldPermissions.DEFAULT, null, IndexPrivilege.MONITOR, true, ".security*")
+            .add(FieldPermissions.DEFAULT, null, IndexPrivilege.INDEX, false, false, ".sec*")
+            .add(FieldPermissions.DEFAULT, null, IndexPrivilege.MONITOR, true, false, ".security*")
             .build();
         RBACAuthorizationInfo authzInfo = new RBACAuthorizationInfo(role, null);
 
@@ -1013,8 +1013,8 @@ public void testCheckRestrictedIndexWildcardPermissions() throws Exception {
         );
 
         role = Role.builder(RESTRICTED_INDICES, "role")
-            .add(FieldPermissions.DEFAULT, null, IndexPrivilege.INDEX, true, ".sec*")
-            .add(FieldPermissions.DEFAULT, null, IndexPrivilege.MONITOR, false, ".security*")
+            .add(FieldPermissions.DEFAULT, null, IndexPrivilege.INDEX, true, false, ".sec*")
+            .add(FieldPermissions.DEFAULT, null, IndexPrivilege.MONITOR, false, false, ".security*")
             .build();
         authzInfo = new RBACAuthorizationInfo(role, null);
 
@@ -1297,6 +1297,7 @@ public void testBuildUserPrivilegeResponse() {
                 Collections.singleton(query),
                 IndexPrivilege.READ,
                 randomBoolean(),
+                false,
                 "index-4",
                 "index-5"
             )
@@ -1912,6 +1913,7 @@ public void testChildSearchActionAuthorizationIsNotSkippedWhenRoleHasDLS() {
                     Set.of(query),
                     IndexPrivilege.READ,
                     randomBoolean(),
+                    false,
                     indices
                 )
                 .build()