Skip to content

Commit d8df234

Browse files
authored
Remove Cloud images from 7.16 (#80742)
We don't actually need Cloud images before v8.0, so remove all references and supporting code.
1 parent 08bee54 commit d8df234

File tree

21 files changed

+12
-476
lines changed

21 files changed

+12
-476
lines changed

.ci/jobs.t/elastic+elasticsearch+periodic+release-tests.yml

Lines changed: 0 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -15,14 +15,5 @@
1515
JAVA16_HOME=$HOME/.java/openjdk16
1616
- shell: |
1717
#!/usr/local/bin/runbld --redirect-stderr
18-
19-
# Fetch beats artifacts
20-
export ES_VERSION=$(grep 'elasticsearch' build-tools-internal/version.properties | awk '{print $3}')
21-
export BEATS_DIR=$(pwd)/distribution/docker/build/artifacts/beats
22-
23-
mkdir -p ${BEATS_DIR}
24-
curl -o "${BEATS_DIR}/metricbeat-${ES_VERSION}-linux-x86_64.tar.gz" https://snapshots-no-kpi.elastic.co/downloads/beats/metricbeat/metricbeat-${ES_VERSION}-SNAPSHOT-linux-x86_64.tar.gz
25-
curl -o "${BEATS_DIR}/filebeat-${ES_VERSION}-linux-x86_64.tar.gz" https://snapshots-no-kpi.elastic.co/downloads/beats/filebeat/filebeat-${ES_VERSION}-SNAPSHOT-linux-x86_64.tar.gz
26-
2718
$WORKSPACE/.ci/scripts/run-gradle.sh -Dbwc.checkout.align=true -Dbuild.snapshot=false \
2819
-Dtests.jvm.argline=-Dbuild.snapshot=false -Dlicense.key=${WORKSPACE}/x-pack/license-tools/src/test/resources/public.key -Dbuild.id=deadbeef build

build-tools-internal/src/main/java/org/elasticsearch/gradle/internal/DockerBase.java

Lines changed: 1 addition & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -18,14 +18,7 @@ public enum DockerBase {
1818
UBI("docker.elastic.co/ubi8/ubi-minimal:latest", "-ubi8"),
1919

2020
// The Iron Bank base image is UBI (albeit hardened), but we are required to parameterize the Docker build
21-
IRON_BANK("${BASE_REGISTRY}/${BASE_IMAGE}:${BASE_TAG}", "-ironbank"),
22-
23-
// Base image with extras for Cloud
24-
CLOUD("ubuntu:20.04", "-cloud"),
25-
26-
// Based on CLOUD above, with more extras. We don't set a base image because
27-
// we programmatically extend from the Cloud image.
28-
CLOUD_ESS(null, "-cloud-ess");
21+
IRON_BANK("${BASE_REGISTRY}/${BASE_IMAGE}:${BASE_TAG}", "-ironbank");
2922

3023
private final String image;
3124
private final String suffix;

build-tools-internal/src/main/java/org/elasticsearch/gradle/internal/InternalDistributionDownloadPlugin.java

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -166,12 +166,6 @@ private static String distributionProjectName(ElasticsearchDistribution distribu
166166
if (distribution.getType() == InternalElasticsearchDistributionTypes.DOCKER_IRONBANK) {
167167
return projectName + "ironbank-docker" + archString + "-export";
168168
}
169-
if (distribution.getType() == InternalElasticsearchDistributionTypes.DOCKER_CLOUD) {
170-
return projectName + "cloud-docker" + archString + "-export";
171-
}
172-
if (distribution.getType() == InternalElasticsearchDistributionTypes.DOCKER_CLOUD_ESS) {
173-
return projectName + "cloud-ess-docker" + archString + "-export";
174-
}
175169
return projectName + distribution.getType().getName();
176170
}
177171

build-tools-internal/src/main/java/org/elasticsearch/gradle/internal/distribution/DockerCloudElasticsearchDistributionType.java

Lines changed: 0 additions & 26 deletions
This file was deleted.

build-tools-internal/src/main/java/org/elasticsearch/gradle/internal/distribution/DockerCloudEssElasticsearchDistributionType.java

Lines changed: 0 additions & 26 deletions
This file was deleted.

build-tools-internal/src/main/java/org/elasticsearch/gradle/internal/distribution/InternalElasticsearchDistributionTypes.java

Lines changed: 1 addition & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -18,16 +18,6 @@ public class InternalElasticsearchDistributionTypes {
1818
public static ElasticsearchDistributionType DOCKER = new DockerElasticsearchDistributionType();
1919
public static ElasticsearchDistributionType DOCKER_UBI = new DockerUbiElasticsearchDistributionType();
2020
public static ElasticsearchDistributionType DOCKER_IRONBANK = new DockerIronBankElasticsearchDistributionType();
21-
public static ElasticsearchDistributionType DOCKER_CLOUD = new DockerCloudElasticsearchDistributionType();
22-
public static ElasticsearchDistributionType DOCKER_CLOUD_ESS = new DockerCloudEssElasticsearchDistributionType();
2321

24-
public static List<ElasticsearchDistributionType> ALL_INTERNAL = List.of(
25-
DEB,
26-
RPM,
27-
DOCKER,
28-
DOCKER_UBI,
29-
DOCKER_IRONBANK,
30-
DOCKER_CLOUD,
31-
DOCKER_CLOUD_ESS
32-
);
22+
public static List<ElasticsearchDistributionType> ALL_INTERNAL = List.of(DEB, RPM, DOCKER, DOCKER_UBI, DOCKER_IRONBANK);
3323
}

build-tools-internal/src/main/java/org/elasticsearch/gradle/internal/test/DistroTestPlugin.java

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -57,8 +57,6 @@
5757
import static org.elasticsearch.gradle.internal.distribution.InternalElasticsearchDistributionTypes.ALL_INTERNAL;
5858
import static org.elasticsearch.gradle.internal.distribution.InternalElasticsearchDistributionTypes.DEB;
5959
import static org.elasticsearch.gradle.internal.distribution.InternalElasticsearchDistributionTypes.DOCKER;
60-
import static org.elasticsearch.gradle.internal.distribution.InternalElasticsearchDistributionTypes.DOCKER_CLOUD;
61-
import static org.elasticsearch.gradle.internal.distribution.InternalElasticsearchDistributionTypes.DOCKER_CLOUD_ESS;
6260
import static org.elasticsearch.gradle.internal.distribution.InternalElasticsearchDistributionTypes.DOCKER_IRONBANK;
6361
import static org.elasticsearch.gradle.internal.distribution.InternalElasticsearchDistributionTypes.DOCKER_UBI;
6462
import static org.elasticsearch.gradle.internal.distribution.InternalElasticsearchDistributionTypes.RPM;
@@ -236,8 +234,6 @@ private static Map<ElasticsearchDistributionType, TaskProvider<?>> lifecycleTask
236234
lifecyleTasks.put(DOCKER, project.getTasks().register(taskPrefix + ".docker"));
237235
lifecyleTasks.put(DOCKER_UBI, project.getTasks().register(taskPrefix + ".docker-ubi"));
238236
lifecyleTasks.put(DOCKER_IRONBANK, project.getTasks().register(taskPrefix + ".docker-ironbank"));
239-
lifecyleTasks.put(DOCKER_CLOUD, project.getTasks().register(taskPrefix + ".docker-cloud"));
240-
lifecyleTasks.put(DOCKER_CLOUD_ESS, project.getTasks().register(taskPrefix + ".docker-cloud-ess"));
241237
lifecyleTasks.put(ARCHIVE, project.getTasks().register(taskPrefix + ".archives"));
242238
lifecyleTasks.put(DEB, project.getTasks().register(taskPrefix + ".packages"));
243239
lifecyleTasks.put(RPM, lifecyleTasks.get(DEB));

distribution/docker/build.gradle

Lines changed: 2 additions & 103 deletions
Original file line numberDiff line numberDiff line change
@@ -33,23 +33,6 @@ repositories {
3333
metadataSources { artifact() }
3434
content { includeGroup 'krallin' }
3535
}
36-
37-
// Cloud builds bundle some beats
38-
ivy {
39-
if (useLocalArtifacts) {
40-
url "file://${buildDir}/artifacts/"
41-
patternLayout {
42-
artifact '/[organisation]/[module]-[revision]-linux-[classifier].[ext]'
43-
}
44-
} else {
45-
url "https://${VersionProperties.isElasticsearchSnapshot() ? 'snapshots' : 'artifacts'}-no-kpi.elastic.co/"
46-
patternLayout {
47-
artifact '/downloads/[organization]/[module]/[module]-[revision]-linux-[classifier].[ext]'
48-
}
49-
}
50-
metadataSources { artifact() }
51-
content { includeGroup 'beats' }
52-
}
5336
}
5437

5538
testFixtures.useFixture()
@@ -59,24 +42,15 @@ configurations {
5942
dockerSource
6043
log4jConfig
6144
tini
62-
repositoryPlugins
63-
nonRepositoryPlugins
64-
filebeat
65-
metricbeat
6645
}
6746

68-
String beatsArch = Architecture.current() == Architecture.AARCH64 ? 'arm64' : 'x86_64'
6947
String tiniArch = Architecture.current() == Architecture.AARCH64 ? 'arm64' : 'amd64'
7048

7149
dependencies {
7250
aarch64DockerSource project(path: ":distribution:archives:linux-aarch64-tar", configuration: 'default')
7351
dockerSource project(path: ":distribution:archives:linux-tar", configuration: 'default')
7452
log4jConfig project(path: ":distribution", configuration: 'log4jConfig')
7553
tini "krallin:tini:0.19.0:${tiniArch}"
76-
repositoryPlugins project(path: ':plugins', configuration: 'repositoryPlugins')
77-
nonRepositoryPlugins project(path: ':plugins', configuration: 'nonRepositoryPlugins')
78-
filebeat "beats:filebeat:${VersionProperties.elasticsearch}:${beatsArch}@tar.gz"
79-
metricbeat "beats:metricbeat:${VersionProperties.elasticsearch}:${beatsArch}@tar.gz"
8054
}
8155

8256
ext.expansions = { Architecture architecture, DockerBase base ->
@@ -254,22 +228,6 @@ void addBuildDockerContextTask(Architecture architecture, DockerBase base) {
254228
}
255229
}
256230

257-
if (base == DockerBase.CLOUD) {
258-
// If we're performing a release build, but `build.id` hasn't been set, we can
259-
// infer that we're not at the Docker building stage of the build, and therefore
260-
// we should skip the beats part of the build.
261-
String buildId = providers.systemProperty('build.id').forUseAtConfigurationTime().getOrNull()
262-
boolean includeBeats = VersionProperties.isElasticsearchSnapshot() == true || buildId != null
263-
264-
from configurations.repositoryPlugins
265-
if (includeBeats) {
266-
from configurations.filebeat
267-
from configurations.metricbeat
268-
}
269-
// For some reason, the artifact name can differ depending on what repository we used.
270-
rename ~/((?:file|metric)beat)-.*\.tar\.gz$/, "\$1-${VersionProperties.elasticsearch}.tar.gz"
271-
}
272-
273231
onlyIf { Architecture.current() == architecture }
274232
}
275233

@@ -324,11 +282,7 @@ private static List<String> generateTags(DockerBase base) {
324282
final String version = VersionProperties.elasticsearch
325283

326284
String image = "elasticsearch${base.suffix}"
327-
328285
String namespace = 'elasticsearch'
329-
if (base == DockerBase.CLOUD || base == DockerBase.CLOUD_ESS) {
330-
namespace += '-ci'
331-
}
332286

333287
return [
334288
"${image}:test",
@@ -371,68 +325,19 @@ void addBuildDockerImageTask(Architecture architecture, DockerBase base) {
371325
onlyIf { Architecture.current() == architecture }
372326
}
373327

374-
if (base != DockerBase.IRON_BANK && base != DockerBase.CLOUD && base != DockerBase.CLOUD_ESS) {
328+
if (base != DockerBase.IRON_BANK) {
375329
tasks.named("assemble").configure {
376330
dependsOn(buildDockerImageTask)
377331
}
378332
}
379333
}
380334

381-
void addBuildEssDockerImageTask(Architecture architecture) {
382-
DockerBase base = DockerBase.CLOUD_ESS
383-
String arch = architecture == Architecture.AARCH64 ? '-aarch64' : ''
384-
String contextDir = "${project.buildDir}/docker-context/elasticsearch${base.suffix}-${VersionProperties.elasticsearch}-docker-build-context${arch}"
385-
386-
final TaskProvider<Sync> buildContextTask =
387-
tasks.register(taskName('build', architecture, base, 'DockerContext'), Sync) {
388-
into contextDir
389-
390-
final Path projectDir = project.projectDir.toPath()
391-
392-
into("plugins") {
393-
from configurations.nonRepositoryPlugins
394-
}
395-
396-
from(projectDir.resolve("src/docker/Dockerfile.cloud-ess")) {
397-
expand([
398-
base_image: "elasticsearch${DockerBase.CLOUD.suffix}:${VersionProperties.elasticsearch}"
399-
])
400-
filter SquashNewlinesFilter
401-
rename ~/Dockerfile\.cloud-ess$/, 'Dockerfile'
402-
}
403-
}
404-
405-
final TaskProvider<DockerBuildTask> buildDockerImageTask =
406-
tasks.register(taskName("build", architecture, base, "DockerImage"), DockerBuildTask) {
407-
408-
TaskProvider<DockerBuildTask> buildCloudTask = tasks.named(taskName("build", architecture, DockerBase.CLOUD, "DockerImage"))
409-
inputs.files(buildCloudTask)
410-
411-
dockerContext.fileProvider(buildContextTask.map { it.getDestinationDir() })
412-
413-
noCache = BuildParams.isCi
414-
baseImages = []
415-
tags = generateTags(base)
416-
417-
onlyIf { Architecture.current() == architecture }
418-
}
419-
420-
tasks.named("assemble").configure {
421-
dependsOn(buildDockerImageTask)
422-
}
423-
}
424-
425335
for (final Architecture architecture : Architecture.values()) {
426336
for (final DockerBase base : DockerBase.values()) {
427-
if (base == DockerBase.CLOUD_ESS) {
428-
continue
429-
}
430337
addBuildDockerContextTask(architecture, base)
431338
addTransformDockerContextTask(architecture, base)
432339
addBuildDockerImageTask(architecture, base)
433340
}
434-
435-
addBuildEssDockerImageTask(architecture)
436341
}
437342

438343
/*
@@ -449,18 +354,12 @@ subprojects { Project subProject ->
449354
base = DockerBase.UBI
450355
} else if (subProject.name.contains('ironbank-')) {
451356
base = DockerBase.IRON_BANK
452-
} else if (subProject.name.contains('cloud-ess-')) {
453-
base = DockerBase.CLOUD_ESS
454-
} else if (subProject.name.contains('cloud-')) {
455-
base = DockerBase.CLOUD
456357
}
457358

458359
final String arch = architecture == Architecture.AARCH64 ? '-aarch64' : ''
459360
final String extension = base == DockerBase.UBI ? 'ubi.tar' :
460361
(base == DockerBase.IRON_BANK ? 'ironbank.tar' :
461-
(base == DockerBase.CLOUD ? 'cloud.tar' :
462-
(base == DockerBase.CLOUD_ESS ? 'cloud-ess.tar' :
463-
'docker.tar')))
362+
'docker.tar')
464363
final String artifactName = "elasticsearch${arch}${base.suffix}_test"
465364

466365
final String exportTaskName = taskName("export", architecture, base, 'DockerImage')

distribution/docker/cloud-docker-aarch64-export/build.gradle

Lines changed: 0 additions & 2 deletions
This file was deleted.

distribution/docker/cloud-docker-export/build.gradle

Lines changed: 0 additions & 2 deletions
This file was deleted.

0 commit comments

Comments
 (0)