smaller builder

Author: dnhatn

server/src/main/java/org/elasticsearch/index/mapper/BlockLoader.java

@@ -567,10 +567,6 @@ interface SingletonLongBuilder extends Builder {
      * Specialized builder for collecting dense arrays of double values.
      */
     interface SingletonDoubleBuilder extends Builder {
-        SingletonDoubleBuilder appendDouble(double value);
-
-        SingletonDoubleBuilder appendDoubles(double[] values, int from, int length);
-
         SingletonDoubleBuilder appendLongs(BlockDocValuesReader.ToDouble toDouble, long[] values, int from, int length);
     }
 

test/framework/src/main/java/org/elasticsearch/index/mapper/TestBlock.java

@@ -263,19 +263,6 @@ public BlockLoader.Block build() {
                         return new TestBlock(Arrays.stream(values).boxed().collect(Collectors.toUnmodifiableList()));
                     }
 
-                    @Override
-                    public BlockLoader.SingletonDoubleBuilder appendDoubles(double[] newValues, int from, int length) {
-                        System.arraycopy(newValues, from, values, count, length);
-                        count += length;
-                        return this;
-                    }
-
-                    @Override
-                    public BlockLoader.SingletonDoubleBuilder appendDouble(double value) {
-                        values[count++] = value;
-                        return this;
-                    }
-
                     @Override
                     public BlockLoader.SingletonDoubleBuilder appendLongs(
                         BlockDocValuesReader.ToDouble toDouble,

x-pack/plugin/esql/compute/src/main/java/org/elasticsearch/compute/lucene/read/SingletonDoubleBuilder.java

@@ -72,19 +72,6 @@ public Block build() {
         return blockFactory.newDoubleArrayVector(values, count).asBlock();
     }
 
-    @Override
-    public BlockLoader.SingletonDoubleBuilder appendDouble(double value) {
-        values[count++] = value;
-        return this;
-    }
-
-    @Override
-    public BlockLoader.SingletonDoubleBuilder appendDoubles(double[] values, int from, int length) {
-        System.arraycopy(values, from, this.values, count, length);
-        count += length;
-        return this;
-    }
-
     @Override
     public BlockLoader.SingletonDoubleBuilder appendLongs(BlockDocValuesReader.ToDouble toDouble, long[] longValues, int from, int length) {
         for (int i = 0; i < length; i++) {

x-pack/plugin/esql/compute/src/test/java/org/elasticsearch/compute/lucene/read/SingletonDoubleBuilderTests.java

@@ -69,14 +69,7 @@ private void testRead(BlockFactory factory) throws IOException {
                     try (var builder = new SingletonDoubleBuilder(ctx.reader().numDocs(), factory)) {
                         for (int i = 0; i < ctx.reader().maxDoc(); i++) {
                             assertThat(docValues.advanceExact(i), equalTo(true));
-                            double value = Double.longBitsToDouble(docValues.longValue());
-                            if (randomBoolean()) {
-                                builder.appendDoubles(new double[] { value }, 0, 1);
-                            } else if (randomBoolean()) {
-                                builder.appendLongs(Double::longBitsToDouble, new long[] { docValues.longValue() }, 0, 1);
-                            } else {
-                                builder.appendDouble(value);
-                            }
+                            builder.appendLongs(Double::longBitsToDouble, new long[] { docValues.longValue() }, 0, 1);
                         }
                         try (var build = (DoubleVector) builder.build().asVector()) {
                             for (int i = 0; i < build.getPositionCount(); i++) {
@@ -115,12 +108,7 @@ public void testMoreValues() throws IOException {
                 try (var builder = new SingletonDoubleBuilder(count - offset, blockFactory())) {
                     for (int i = offset; i < leafReader.maxDoc(); i++) {
                         assertThat(docValues.advanceExact(i), equalTo(true));
-                        double value = Double.longBitsToDouble(docValues.longValue());
-                        if (randomBoolean()) {
-                            builder.appendDoubles(new double[] { value }, 0, 1);
-                        } else {
-                            builder.appendDouble(value);
-                        }
+                        builder.appendLongs(Double::longBitsToDouble, new long[] { docValues.longValue() }, 0, 1);
                     }
                     try (var build = (DoubleVector) builder.build().asVector()) {
                         assertThat(build.getPositionCount(), equalTo(count - offset));