Remove type param from BaseNodesRequest (#114399)

This type parameter is only needed so that the `.timeout(TimeValue)`
method returns a request of the right type, but this still requires an
unchecked cast. Yet there's no real need to return anything from this
method, we can just use a regular setter. This commit does that.

Author: DaveCTurner

modules/ingest-geoip/src/main/java/org/elasticsearch/ingest/geoip/direct/GetDatabaseConfigurationAction.java

@@ -41,7 +41,7 @@ protected GetDatabaseConfigurationAction() {
         super(NAME);
     }
 
-    public static class Request extends BaseNodesRequest<Request> {
+    public static class Request extends BaseNodesRequest {
         private final String[] databaseIds;
 
         public Request(String... databaseIds) {

modules/ingest-geoip/src/main/java/org/elasticsearch/ingest/geoip/stats/GeoIpStatsAction.java

@@ -37,7 +37,7 @@ public class GeoIpStatsAction {
 
     private GeoIpStatsAction() {/* no instances */}
 
-    public static class Request extends BaseNodesRequest<Request> implements ToXContentObject {
+    public static class Request extends BaseNodesRequest implements ToXContentObject {
 
         public Request() {
             super((String[]) null);

server/src/main/java/org/elasticsearch/action/admin/cluster/node/capabilities/NodesCapabilitiesRequest.java

@@ -16,7 +16,7 @@
 
 import java.util.Set;
 
-public class NodesCapabilitiesRequest extends BaseNodesRequest<NodesCapabilitiesRequest> {
+public class NodesCapabilitiesRequest extends BaseNodesRequest {
 
     private RestRequest.Method method = RestRequest.Method.GET;
     private String path = "/";

server/src/main/java/org/elasticsearch/action/admin/cluster/node/features/NodesFeaturesRequest.java

@@ -11,7 +11,7 @@
 
 import org.elasticsearch.action.support.nodes.BaseNodesRequest;
 
-public class NodesFeaturesRequest extends BaseNodesRequest<NodesFeaturesRequest> {
+public class NodesFeaturesRequest extends BaseNodesRequest {
     public NodesFeaturesRequest(String... nodes) {
         super(nodes);
     }

server/src/main/java/org/elasticsearch/action/admin/cluster/node/hotthreads/NodesHotThreadsRequest.java

@@ -14,7 +14,7 @@
 import org.elasticsearch.core.TimeValue;
 import org.elasticsearch.monitor.jvm.HotThreads;
 
-public class NodesHotThreadsRequest extends BaseNodesRequest<NodesHotThreadsRequest> {
+public class NodesHotThreadsRequest extends BaseNodesRequest {
 
     final HotThreads.RequestOptions requestOptions;
 

server/src/main/java/org/elasticsearch/action/admin/cluster/node/info/NodesInfoRequest.java

@@ -18,7 +18,7 @@
 /**
  * A request to get node (cluster) level information.
  */
-public final class NodesInfoRequest extends BaseNodesRequest<NodesInfoRequest> {
+public final class NodesInfoRequest extends BaseNodesRequest {
 
     private final NodesInfoMetrics nodesInfoMetrics;
 

server/src/main/java/org/elasticsearch/action/admin/cluster/node/reload/NodesReloadSecureSettingsRequest.java

@@ -33,7 +33,7 @@
 /**
  * Request for a reload secure settings action
  */
-public class NodesReloadSecureSettingsRequest extends BaseNodesRequest<NodesReloadSecureSettingsRequest> {
+public class NodesReloadSecureSettingsRequest extends BaseNodesRequest {
 
     /**
      * The password is used to re-read and decrypt the contents

server/src/main/java/org/elasticsearch/action/admin/cluster/node/shutdown/PrevalidateShardPathRequest.java

@@ -16,7 +16,7 @@
 import java.util.Objects;
 import java.util.Set;
 
-public class PrevalidateShardPathRequest extends BaseNodesRequest<PrevalidateShardPathRequest> {
+public class PrevalidateShardPathRequest extends BaseNodesRequest {
 
     private final Set<ShardId> shardIds;
 

server/src/main/java/org/elasticsearch/action/admin/cluster/node/shutdown/TransportPrevalidateNodeRemovalAction.java

@@ -229,7 +229,8 @@ private void doPrevalidation(
                 ) // Convert to ShardId
                 .collect(Collectors.toSet());
             var nodeIds = requestNodes.stream().map(DiscoveryNode::getId).toList().toArray(new String[0]);
-            var checkShardsRequest = new PrevalidateShardPathRequest(redShards, nodeIds).timeout(request.timeout());
+            var checkShardsRequest = new PrevalidateShardPathRequest(redShards, nodeIds);
+            checkShardsRequest.setTimeout(request.timeout());
             client.execute(TransportPrevalidateShardPathAction.TYPE, checkShardsRequest, new ActionListener<>() {
                 @Override
                 public void onResponse(PrevalidateShardPathResponse response) {

server/src/main/java/org/elasticsearch/action/admin/cluster/node/stats/NodesStatsRequest.java

@@ -25,7 +25,7 @@
 /**
  * A request to get node (cluster) level stats.
  */
-public class NodesStatsRequest extends BaseNodesRequest<NodesStatsRequest> {
+public class NodesStatsRequest extends BaseNodesRequest {
 
     private final NodesStatsRequestParameters nodesStatsRequestParameters;