Fix failure-path test

Author: DaveCTurner

x-pack/plugin/snapshot-repo-test-kit/src/internalClusterTest/java/org/elasticsearch/repositories/blobstore/testkit/analyze/RepositoryAnalysisFailureIT.java

@@ -178,14 +178,24 @@ public void testFailsOnCopyAfterWrite() {
         request.maxBlobSize(ByteSizeValue.ofBytes(10L));
         request.abortWritePermitted(false);
 
+        final AtomicBoolean failedCopy = new AtomicBoolean();
         blobStore.setDisruption(new Disruption() {
             @Override
             public void onCopy() throws IOException {
+                failedCopy.set(true);
                 throw new IOException("simulated");
             }
         });
 
-        assertAnalysisFailureMessage(analyseRepositoryExpectFailure(request).getMessage());
+        safeAwait((ActionListener<RepositoryAnalyzeAction.Response> l) -> analyseRepository(request, l.delegateResponse((ll, e) -> {
+            if (ExceptionsHelper.unwrapCause(e) instanceof RepositoryVerificationException repositoryVerificationException) {
+                assertAnalysisFailureMessage(repositoryVerificationException.getMessage());
+                assertTrue("did not fail a copy operation, so why did the verification fail?", failedCopy.get());
+                ll.onResponse(null);
+            } else {
+                ll.onFailure(e);
+            }
+        })));
     }
 
     public void testFailsOnChecksumMismatch() {