Skip to content

Commit daddb62

Browse files
committed
revert rebasing update
1 parent 2008096 commit daddb62

File tree

32 files changed

+16
-1459
lines changed

32 files changed

+16
-1459
lines changed

docs/changelog/117176.yaml

Lines changed: 0 additions & 5 deletions
This file was deleted.

docs/changelog/121109.yaml

Lines changed: 0 additions & 6 deletions
This file was deleted.

docs/changelog/121325.yaml

Lines changed: 0 additions & 5 deletions
This file was deleted.

muted-tests.yml

Lines changed: 0 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -379,18 +379,6 @@ tests:
379379
- class: org.elasticsearch.smoketest.DocsClientYamlTestSuiteIT
380380
method: test {yaml=reference/rest-api/common-options/line_125}
381381
issue: https://github.com/elastic/elasticsearch/issues/121338
382-
- class: org.elasticsearch.smoketest.DocsClientYamlTestSuiteIT
383-
method: test {yaml=reference/snapshot-restore/apis/get-snapshot-api/line_751}
384-
issue: https://github.com/elastic/elasticsearch/issues/121345
385-
- class: org.elasticsearch.xpack.security.profile.ProfileIntegTests
386-
method: testHasPrivileges
387-
issue: https://github.com/elastic/elasticsearch/issues/121346
388-
- class: org.elasticsearch.xpack.security.profile.ProfileIntegTests
389-
method: testActivateProfile
390-
issue: https://github.com/elastic/elasticsearch/issues/121151
391-
- class: org.elasticsearch.smoketest.SmokeTestMultiNodeClientYamlTestSuiteIT
392-
method: test {yaml=search.vectors/42_knn_search_int4_flat/Vector similarity with filter only}
393-
issue: https://github.com/elastic/elasticsearch/issues/121350
394382

395383
# Examples:
396384
#

rest-api-spec/build.gradle

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -73,5 +73,4 @@ tasks.named("yamlRestCompatTestTransform").configure ({ task ->
7373
task.skipTest("index/92_metrics_auto_subobjects/Root without subobjects with synthetic source", "_source.mode mapping attribute is no-op since 9.0.0")
7474
task.skipTest("index/91_metrics_no_subobjects/Metrics object indexing with synthetic source", "_source.mode mapping attribute is no-op since 9.0.0")
7575
task.skipTest("index/91_metrics_no_subobjects/Root without subobjects with synthetic source", "_source.mode mapping attribute is no-op since 9.0.0")
76-
task.skipTest("indices.create/20_synthetic_source/synthetic_source with copy_to inside nested object", "temporary until backported")
7776
})

rest-api-spec/src/yamlRestTest/resources/rest-api-spec/test/mapping/10_copy_to.yml

Lines changed: 0 additions & 41 deletions
This file was deleted.

server/src/main/java/org/elasticsearch/TransportVersions.java

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -171,7 +171,6 @@ static TransportVersion def(int id) {
171171
public static final TransportVersion LINEAR_RETRIEVER_SUPPORT = def(8_837_00_0);
172172
public static final TransportVersion TIMEOUT_GET_PARAM_FOR_RESOLVE_CLUSTER = def(8_838_00_0);
173173
public static final TransportVersion INFERENCE_REQUEST_ADAPTIVE_RATE_LIMITING = def(8_839_00_0);
174-
public static final TransportVersion ML_INFERENCE_IBM_WATSONX_RERANK_ADDED = def(8_840_00_0);
175174

176175
/*
177176
* STOP! READ THIS FIRST! No, really,

server/src/main/java/org/elasticsearch/index/mapper/DocumentParserContext.java

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -50,13 +50,6 @@ private Wrapper(ObjectMapper parent, DocumentParserContext in) {
5050
this.in = in;
5151
}
5252

53-
// Used to create a copy_to context.
54-
// It is important to reset `dynamic` here since it is possible that we copy into a completely different object.
55-
private Wrapper(RootObjectMapper root, DocumentParserContext in) {
56-
super(root, ObjectMapper.Dynamic.getRootDynamic(in.mappingLookup()), in);
57-
this.in = in;
58-
}
59-
6053
@Override
6154
public Iterable<LuceneDocument> nonRootDocuments() {
6255
return in.nonRootDocuments();
@@ -718,7 +711,6 @@ in synthetic _source (to be consistent with stored _source).
718711

719712
ContentPath path = new ContentPath();
720713
XContentParser parser = DotExpandingXContentParser.expandDots(new CopyToParser(copyToField, parser()), path);
721-
722714
return new Wrapper(root(), this) {
723715
@Override
724716
public ContentPath path() {

server/src/main/java/org/elasticsearch/index/mapper/MapperFeatures.java

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,6 @@ public class MapperFeatures implements FeatureSpecification {
3030
public static final NodeFeature META_FETCH_FIELDS_ERROR_CODE_CHANGED = new NodeFeature("meta_fetch_fields_error_code_changed");
3131
public static final NodeFeature SPARSE_VECTOR_STORE_SUPPORT = new NodeFeature("mapper.sparse_vector.store_support");
3232
public static final NodeFeature SORT_FIELDS_CHECK_FOR_NESTED_OBJECT_FIX = new NodeFeature("mapper.nested.sorting_fields_check_fix");
33-
public static final NodeFeature DYNAMIC_HANDLING_IN_COPY_TO = new NodeFeature("mapper.copy_to.dynamic_handling");
3433

3534
@Override
3635
public Set<NodeFeature> getTestFeatures() {
@@ -46,9 +45,8 @@ public Set<NodeFeature> getTestFeatures() {
4645
CONSTANT_KEYWORD_SYNTHETIC_SOURCE_WRITE_FIX,
4746
META_FETCH_FIELDS_ERROR_CODE_CHANGED,
4847
SPARSE_VECTOR_STORE_SUPPORT,
49-
COUNTED_KEYWORD_SYNTHETIC_SOURCE_NATIVE_SUPPORT,
5048
SORT_FIELDS_CHECK_FOR_NESTED_OBJECT_FIX,
51-
DYNAMIC_HANDLING_IN_COPY_TO,
49+
COUNTED_KEYWORD_SYNTHETIC_SOURCE_NATIVE_SUPPORT,
5250
SourceFieldMapper.SYNTHETIC_RECOVERY_SOURCE,
5351
ObjectMapper.SUBOBJECTS_FALSE_MAPPING_UPDATE_FIX
5452
);

test/framework/src/main/java/org/elasticsearch/logsdb/datageneration/datasource/DefaultMappingParametersHandler.java

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,6 +11,7 @@
1111

1212
import org.elasticsearch.index.mapper.Mapper;
1313
import org.elasticsearch.index.mapper.ObjectMapper;
14+
import org.elasticsearch.logsdb.datageneration.fields.DynamicMapping;
1415
import org.elasticsearch.test.ESTestCase;
1516

1617
import java.util.HashMap;
@@ -49,7 +50,11 @@ private Supplier<Map<String, Object>> keywordMapping(
4950
// We only add copy_to to keywords because we get into trouble with numeric fields that are copied to dynamic fields.
5051
// If first copied value is numeric, dynamic field is created with numeric field type and then copy of text values fail.
5152
// Actual value being copied does not influence the core logic of copy_to anyway.
52-
if (ESTestCase.randomDouble() <= 0.05) {
53+
//
54+
// TODO
55+
// We don't use copy_to on fields that are inside an object with dynamic: strict
56+
// because we'll hit https://github.com/elastic/elasticsearch/issues/113049.
57+
if (request.dynamicMapping() != DynamicMapping.FORBIDDEN && ESTestCase.randomDouble() <= 0.05) {
5358
var options = request.eligibleCopyToFields()
5459
.stream()
5560
.filter(f -> f.equals(request.fieldName()) == false)

0 commit comments

Comments
 (0)