Skip to content

Commit db3ccdd

Browse files
authored
[Build] Do not create empty buildkite build artifacts (#117400) (#117425)
when building nesting bwc distros we tend to generate empty buildkite artifacts. Lets not create empty archives
1 parent c36967c commit db3ccdd

File tree

1 file changed

+6
-1
lines changed

1 file changed

+6
-1
lines changed

build-tools-internal/src/main/java/org/elasticsearch/gradle/internal/ElasticsearchBuildCompletePlugin.java

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -147,12 +147,17 @@ interface Parameters extends FlowParameters {
147147
@SuppressWarnings("checkstyle:DescendantToken")
148148
@Override
149149
public void execute(BuildFinishedFlowAction.Parameters parameters) throws FileNotFoundException {
150+
List<File> filesToArchive = parameters.getFilteredFiles().get();
151+
if (filesToArchive.isEmpty()) {
152+
return;
153+
}
150154
File uploadFile = parameters.getUploadFile().get();
151155
if (uploadFile.exists()) {
152156
getFileSystemOperations().delete(spec -> spec.delete(uploadFile));
153157
}
154158
uploadFile.getParentFile().mkdirs();
155-
createBuildArchiveTar(parameters.getFilteredFiles().get(), parameters.getProjectDir().get(), uploadFile);
159+
160+
createBuildArchiveTar(filesToArchive, parameters.getProjectDir().get(), uploadFile);
156161
if (uploadFile.exists() && "true".equals(System.getenv("BUILDKITE"))) {
157162
String uploadFilePath = uploadFile.getName();
158163
File uploadFileDir = uploadFile.getParentFile();

0 commit comments

Comments
 (0)