Skip to content

Commit dc80bef

Browse files
Test nit
1 parent 553b08a commit dc80bef

File tree

1 file changed

+10
-7
lines changed

1 file changed

+10
-7
lines changed

server/src/test/java/org/elasticsearch/index/engine/ThreadPoolMergeSchedulerTests.java

Lines changed: 10 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,7 @@
1010
package org.elasticsearch.index.engine;
1111

1212
import org.apache.lucene.index.MergePolicy;
13+
import org.apache.lucene.index.MergePolicy.OneMerge;
1314
import org.apache.lucene.index.MergeScheduler.MergeSource;
1415
import org.apache.lucene.index.MergeTrigger;
1516
import org.apache.lucene.store.MergeInfo;
@@ -66,11 +67,11 @@ public void testMergesExecuteInSizeOrder() throws IOException {
6667
threadPoolMergeExecutorService
6768
)
6869
) {
69-
List<MergePolicy.OneMerge> executedMergesList = new ArrayList<>();
70+
List<OneMerge> executedMergesList = new ArrayList<>();
7071
int mergeCount = randomIntBetween(2, 10);
7172
for (int i = 0; i < mergeCount; i++) {
7273
MergeSource mergeSource = mock(MergeSource.class);
73-
MergePolicy.OneMerge oneMerge = mock(MergePolicy.OneMerge.class);
74+
OneMerge oneMerge = mock(OneMerge.class);
7475
when(oneMerge.getStoreMergeInfo()).thenReturn(
7576
new MergeInfo(
7677
randomNonNegativeInt(),
@@ -80,11 +81,13 @@ public void testMergesExecuteInSizeOrder() throws IOException {
8081
)
8182
);
8283
when(oneMerge.getMergeProgress()).thenReturn(new MergePolicy.OneMergeProgress());
83-
when(mergeSource.getNextMerge()).thenReturn(oneMerge, (MergePolicy.OneMerge) null);
84+
when(mergeSource.getNextMerge()).thenReturn(oneMerge, (OneMerge) null);
8485
doAnswer(invocation -> {
85-
executedMergesList.add((MergePolicy.OneMerge) invocation.getArguments()[0]);
86+
OneMerge merge = (OneMerge) invocation.getArguments()[0];
87+
assertFalse(merge.isAborted());
88+
executedMergesList.add(merge);
8689
return null;
87-
}).when(mergeSource).merge(any(MergePolicy.OneMerge.class));
90+
}).when(mergeSource).merge(any(OneMerge.class));
8891
threadPoolMergeScheduler.merge(mergeSource, randomFrom(MergeTrigger.values()));
8992
}
9093
deterministicTaskQueue.runAllTasks();
@@ -109,7 +112,7 @@ public void testAutoIOThrottleForMergeTasksWhenSchedulerDisablesIt() throws Exce
109112
IndexSettings indexSettings = IndexSettingsModule.newIndexSettings("index", settings);
110113
ThreadPoolMergeExecutorService threadPoolMergeExecutorService = mock(ThreadPoolMergeExecutorService.class);
111114
MergePolicy.OneMergeProgress oneMergeProgress = new MergePolicy.OneMergeProgress();
112-
MergePolicy.OneMerge oneMerge = mock(MergePolicy.OneMerge.class);
115+
OneMerge oneMerge = mock(OneMerge.class);
113116
when(oneMerge.getStoreMergeInfo()).thenReturn(
114117
new MergeInfo(randomNonNegativeInt(), randomNonNegativeLong(), randomBoolean(), randomFrom(-1, randomNonNegativeInt()))
115118
);
@@ -143,7 +146,7 @@ public void testAutoIOThrottleForMergeTasks() throws Exception {
143146
}
144147
IndexSettings indexSettings = IndexSettingsModule.newIndexSettings("index", settings);
145148
MergePolicy.OneMergeProgress oneMergeProgress = new MergePolicy.OneMergeProgress();
146-
MergePolicy.OneMerge oneMerge = mock(MergePolicy.OneMerge.class);
149+
OneMerge oneMerge = mock(OneMerge.class);
147150
// forced merge with a set number of segments
148151
when(oneMerge.getStoreMergeInfo()).thenReturn(
149152
new MergeInfo(randomNonNegativeInt(), randomNonNegativeLong(), randomBoolean(), randomNonNegativeInt())

0 commit comments

Comments
 (0)