Skip to content

Commit dca3e54

Browse files
committed
Minor cleanup
1 parent 9912426 commit dca3e54

File tree

1 file changed

+0
-7
lines changed

1 file changed

+0
-7
lines changed

x-pack/plugin/inference/src/main/java/org/elasticsearch/xpack/inference/mapper/SemanticTextFieldMapper.java

Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -331,11 +331,6 @@ public SemanticTextFieldMapper build(MapperBuilderContext context) {
331331
}
332332
}
333333

334-
// I don't think we need this - TODO delete this
335-
// if (modelSettings.get() != null) {
336-
// validateServiceSettings(modelSettings.get(), resolvedModelSettings);
337-
// }
338-
339334
// Validate any specified index options against existing or default index options
340335
SemanticTextIndexOptions resolvedIndexOptions = indexOptions.getValue();
341336
if (context.getMergeReason() != MapperService.MergeReason.MAPPING_RECOVERY) {
@@ -1255,7 +1250,6 @@ private static boolean canMergeIndexOptions(SemanticTextIndexOptions previous, S
12551250
return true;
12561251
}
12571252

1258-
// TODO address merging to/from default index options
12591253
if (previous == null || current == null) {
12601254
return true;
12611255
}
@@ -1264,7 +1258,6 @@ private static boolean canMergeIndexOptions(SemanticTextIndexOptions previous, S
12641258
conflicts.addConflict(INDEX_OPTIONS_FIELD, "Incompatible index options");
12651259
}
12661260

1267-
// TODO clean this up a bit
12681261
if (previous.type() == SemanticTextIndexOptions.SupportedIndexOptions.DENSE_VECTOR) {
12691262
DenseVectorFieldMapper.DenseVectorIndexOptions previousDenseOptions = (DenseVectorFieldMapper.DenseVectorIndexOptions) previous
12701263
.indexOptions();

0 commit comments

Comments
 (0)