Eliminate publicLookup helper.

This seemed helpful, but it probably causes more harm than good by causing
confusing errors when publicLookup doesn't have the required access. Better to
make the caller pass a Lookup object that has the required access.

Author: prdoyle

libs/x-content/src/main/java/org/elasticsearch/xcontent/ConstructingObjectParser.java

@@ -158,26 +158,6 @@ public static <R extends Record, Context> ConstructingObjectParser<R, Context> f
         return new ConstructingObjectParser<>(name, ignoreUnknownFields, (args, context) -> builder.apply(args));
     }
 
-    /**
-     * Build a parser for the given {@code recordClass}.
-     *
-     * @param name The name given to the delegate ObjectParser for error identification. Use what you'd use if the object worked with
-     *        ObjectParser.
-     * @param ignoreUnknownFields Should this parser ignore unknown fields? This should generally be set to true only when parsing responses
-     *        from external systems, never when parsing requests from users.
-     * @param recordClass the {@link Class} of the {@link Record} type to build.
-     *                    It must be a public class with a public canonical constructor, in a package that is exported unconditionally;
-     *                    otherwise, you'll need {@link #forRecord(String, boolean, Class, MethodHandles.Lookup)} instead.
-     * @return a function suitable to use as the {@code builder} argument for one of the constructors of this class.
-     */
-    public static <R extends Record, Context> ConstructingObjectParser<R, Context> forRecord(
-        String name,
-        boolean ignoreUnknownFields,
-        Class<R> recordClass
-    ) {
-        return forRecord(name, ignoreUnknownFields, recordClass, MethodHandles.publicLookup());
-    }
-
     private static <R extends Record> Function<Object[], R> recordBuilder(Class<R> recordClass, MethodHandles.Lookup lookup) {
         Class<?>[] ctorArgs = Arrays.stream(recordClass.getRecordComponents()).map(RecordComponent::getType).toArray(Class<?>[]::new);
         MethodHandle ctor;

modules/ingest-geoip/src/main/java/org/elasticsearch/ingest/geoip/direct/DatabaseConfiguration.java

@@ -25,6 +25,7 @@
 import org.elasticsearch.xcontent.XContentParser;
 
 import java.io.IOException;
+import java.lang.invoke.MethodHandles;
 import java.nio.charset.StandardCharsets;
 import java.util.Arrays;
 import java.util.Objects;
@@ -262,7 +263,8 @@ public String getWriteableName() {
         private static final ConstructingObjectParser<Maxmind, Void> PARSER = ConstructingObjectParser.forRecord(
             "maxmind",
             false,
-            Maxmind.class
+            Maxmind.class,
+            MethodHandles.lookup()
         );
 
         static {

server/src/main/java/org/elasticsearch/cluster/metadata/DataStreamAutoShardingEvent.java

@@ -21,6 +21,7 @@
 import org.elasticsearch.xcontent.XContentParser;
 
 import java.io.IOException;
+import java.lang.invoke.MethodHandles;
 import java.util.function.LongSupplier;
 
 /**
@@ -39,7 +40,8 @@ public record DataStreamAutoShardingEvent(String triggerIndexName, int targetNum
     public static final ConstructingObjectParser<DataStreamAutoShardingEvent, Void> PARSER = ConstructingObjectParser.forRecord(
         "auto_sharding",
         false,
-        DataStreamAutoShardingEvent.class
+        DataStreamAutoShardingEvent.class,
+        MethodHandles.lookup()
     );
 
     static {

server/src/main/java/org/elasticsearch/cluster/metadata/DataStreamFailureStore.java

@@ -25,6 +25,7 @@
 import org.elasticsearch.xcontent.XContentParser;
 
 import java.io.IOException;
+import java.lang.invoke.MethodHandles;
 
 /**
  * Holds the data stream failure store metadata that enable or disable the failure store of a data stream. Currently, it
@@ -47,7 +48,8 @@ public record DataStreamFailureStore(@Nullable Boolean enabled, @Nullable DataSt
     public static final ConstructingObjectParser<DataStreamFailureStore, Void> PARSER = ConstructingObjectParser.forRecord(
         FAILURE_STORE,
         false,
-        DataStreamFailureStore.class
+        DataStreamFailureStore.class,
+        MethodHandles.lookup()
     );
 
     static {

server/src/main/java/org/elasticsearch/cluster/metadata/DataStreamOptions.java

@@ -24,6 +24,7 @@
 import org.elasticsearch.xcontent.XContentParser;
 
 import java.io.IOException;
+import java.lang.invoke.MethodHandles;
 
 import static org.elasticsearch.cluster.metadata.DataStreamFailureStore.FAILURE_STORE;
 
@@ -45,7 +46,8 @@ public record DataStreamOptions(@Nullable DataStreamFailureStore failureStore)
     public static final ConstructingObjectParser<DataStreamOptions, Void> PARSER = ConstructingObjectParser.forRecord(
         "options",
         false,
-        DataStreamOptions.class
+        DataStreamOptions.class,
+        MethodHandles.lookup()
     );
 
     static {

server/src/main/java/org/elasticsearch/cluster/metadata/IndexMetadataStats.java

@@ -23,6 +23,7 @@
 import org.elasticsearch.xcontent.XContentParser;
 
 import java.io.IOException;
+import java.lang.invoke.MethodHandles;
 import java.util.Arrays;
 import java.util.Objects;
 
@@ -134,7 +135,8 @@ public record AverageShardSize(long totalSizeInBytes, int numberOfShards) implem
         private static final ConstructingObjectParser<AverageShardSize, Void> PARSER = ConstructingObjectParser.forRecord(
             "average_shard_size",
             false,
-            AverageShardSize.class
+            AverageShardSize.class,
+            MethodHandles.lookup()
         );
 
         static {

x-pack/plugin/security/src/main/java/org/elasticsearch/xpack/security/profile/ProfileDocument.java

@@ -23,6 +23,7 @@
 import org.elasticsearch.xpack.core.security.user.User;
 
 import java.io.IOException;
+import java.lang.invoke.MethodHandles;
 import java.nio.charset.StandardCharsets;
 import java.security.MessageDigest;
 import java.time.Instant;
@@ -125,25 +126,18 @@ public static ProfileDocument fromXContent(XContentParser parser) {
         return PARSER.apply(parser, null);
     }
 
-    @SuppressWarnings("unchecked")
     static final ConstructingObjectParser<ProfileDocumentUser, Void> PROFILE_DOC_USER_PARSER = ConstructingObjectParser.forRecord(
         "user_profile_document_user",
         false,
-        ProfileDocumentUser.class
+        ProfileDocumentUser.class,
+        MethodHandles.lookup()
     );
 
-    @SuppressWarnings("unchecked")
-    static final ConstructingObjectParser<ProfileDocument, Void> PROFILE_DOC_PARSER = new ConstructingObjectParser<>(
+    static final ConstructingObjectParser<ProfileDocument, Void> PROFILE_DOC_PARSER = ConstructingObjectParser.forRecord(
         "user_profile_document",
         false,
-        (args, v) -> new ProfileDocument(
-            (String) args[0],
-            (boolean) args[1],
-            (long) args[2],
-            (ProfileDocumentUser) args[3],
-            (Map<String, Object>) args[4],
-            (BytesReference) args[5]
-        )
+        ProfileDocument.class,
+        MethodHandles.lookup()
     );
 
     static final ConstructingObjectParser<ProfileDocument, Void> PARSER = new ConstructingObjectParser<>(