improve

Author: weizijun

server/src/internalClusterTest/java/org/elasticsearch/search/KnnSearchIT.java

@@ -50,30 +50,22 @@ private XContentBuilder createKnnMapping() throws Exception {
     public void testKnnSearchWithScroll() throws Exception {
         Client client = client();
 
-        // create index
         client.admin().indices().prepareCreate(INDEX_NAME).setMapping(createKnnMapping()).get();
 
-        // 插入测试数据
         int count = randomIntBetween(10, 20);
         for (int i = 0; i < count; i++) {
-            client.prepareIndex(INDEX_NAME)
-                .setSource(XContentType.JSON, VECTOR_FIELD, new float[]{i, i})
-                .get();
+            client.prepareIndex(INDEX_NAME).setSource(XContentType.JSON, VECTOR_FIELD, new float[] { i, i }).get();
         }
 
-
         refresh(INDEX_NAME);
 
-        // 构建KNN搜索请求
         SearchSourceBuilder sourceBuilder = new SearchSourceBuilder();
         int k = count / 2;
-        sourceBuilder.knnSearch(List.of(new KnnSearchBuilder(VECTOR_FIELD, new float[]{0, 0}, k, k, null, null)));
+        sourceBuilder.knnSearch(List.of(new KnnSearchBuilder(VECTOR_FIELD, new float[] { 0, 0 }, k, k, null, null)));
 
         SearchRequest searchRequest = new SearchRequest(INDEX_NAME);
-        searchRequest.source(sourceBuilder)
-            .scroll(TimeValue.timeValueMinutes(1));
+        searchRequest.source(sourceBuilder).scroll(TimeValue.timeValueMinutes(1));
 
-        // 执行首次搜索
         SearchResponse firstResponse = client.search(searchRequest).actionGet();
         assertThat(firstResponse.getScrollId(), notNullValue());
         assertThat(firstResponse.getHits().getHits().length, equalTo(k));
@@ -90,7 +82,6 @@ public void testKnnSearchWithScroll() throws Exception {
             assertThat(scrollResponse.getHits().getTotalHits().value(), equalTo((long) k));
         }
 
-        // 清理Scroll上下文
         client.prepareClearScroll().addScrollId(firstResponse.getScrollId()).get();
     }
 }

server/src/main/java/org/elasticsearch/search/internal/LegacyReaderContext.java

@@ -73,6 +73,7 @@ public Engine.Searcher acquireSearcher(String source) {
     @Override
     public ShardSearchRequest getShardSearchRequest(ShardSearchRequest other) {
         if (other != null) {
+            // the source builder maybe changed in knn query or another case
             shardSearchRequest.source(other.source());
         }
         return shardSearchRequest;