Make packaging test deletes robust for Windows (#135857)

Windows has crazy file locking behavior. This commit adjusts the rm
utility method used by many tests to internally allow retries when on
Windows, rather than explicitly needing to call rmWithRetries which can
be missed.

relates #113177

Author: rjernst

qa/packaging/src/test/java/org/elasticsearch/packaging/util/Cleanup.java

@@ -13,12 +13,10 @@
 import org.apache.logging.log4j.Logger;
 
 import java.nio.file.Files;
-import java.nio.file.Path;
 import java.nio.file.Paths;
 import java.util.Arrays;
 import java.util.Collections;
 import java.util.List;
-import java.util.function.Consumer;
 
 import static org.elasticsearch.packaging.test.PackagingTestCase.getRootTempDir;
 import static org.elasticsearch.packaging.util.FileUtils.lsGlob;
@@ -75,11 +73,9 @@ public static void cleanEverything() throws Exception {
         // when we run es as a role user on windows, add the equivalent here
         // delete files that may still exist
 
-        lsGlob(getRootTempDir(), "elasticsearch*").forEach(Platforms.WINDOWS ? FileUtils::rmWithRetries : FileUtils::rm);
+        lsGlob(getRootTempDir(), "elasticsearch*").forEach(FileUtils::rm);
         final List<String> filesToDelete = Platforms.WINDOWS ? ELASTICSEARCH_FILES_WINDOWS : ELASTICSEARCH_FILES_LINUX;
-        // windows needs leniency due to asinine releasing of file locking async from a process exiting
-        Consumer<? super Path> rm = Platforms.WINDOWS ? FileUtils::rmWithRetries : FileUtils::rm;
-        filesToDelete.stream().map(Paths::get).filter(Files::exists).forEach(rm);
+        filesToDelete.stream().map(Paths::get).filter(Files::exists).forEach(FileUtils::rm);
     }
 
     private static void purgePackagesLinux() {

qa/packaging/src/test/java/org/elasticsearch/packaging/util/FileUtils.java

@@ -75,16 +75,21 @@ public static List<Path> lsGlob(Path directory, String glob) {
     }
 
     public static void rm(Path... paths) {
-        try {
-            IOUtils.rm(paths);
-        } catch (IOException e) {
-            throw new RuntimeException(e);
+        if (Platforms.WINDOWS) {
+            rmWithRetries(paths);
+        } else {
+            try {
+                IOUtils.rm(paths);
+            } catch (IOException e) {
+                throw new UncheckedIOException(e);
+            }
         }
     }
 
-    public static void rmWithRetries(Path... paths) {
+    // windows needs leniency due to asinine releasing of file locking async from a process exiting
+    private static void rmWithRetries(Path... paths) {
         int tries = 10;
-        Exception exception = null;
+        IOException exception = null;
         while (tries-- > 0) {
             try {
                 IOUtils.rm(paths);
@@ -103,7 +108,7 @@ public static void rmWithRetries(Path... paths) {
                 return;
             }
         }
-        throw new RuntimeException(exception);
+        throw new UncheckedIOException(exception);
     }
 
     public static Path mktempDir(Path path) {