Cleaning it up

Author: mridula-s109

x-pack/plugin/search-business-rules/src/main/java/org/elasticsearch/xpack/searchbusinessrules/retriever/PinnedRankDoc.java

@@ -8,11 +8,11 @@
 package org.elasticsearch.xpack.searchbusinessrules.retriever;
 
 import org.apache.lucene.search.Explanation;
+import org.elasticsearch.TransportVersion;
+import org.elasticsearch.TransportVersions;
 import org.elasticsearch.common.io.stream.StreamInput;
 import org.elasticsearch.common.io.stream.StreamOutput;
 import org.elasticsearch.search.rank.RankDoc;
-import org.elasticsearch.TransportVersion;
-import org.elasticsearch.TransportVersions;
 
 import java.io.IOException;
 import java.util.Objects;

x-pack/plugin/search-business-rules/src/main/java/org/elasticsearch/xpack/searchbusinessrules/retriever/PinnedRetrieverBuilder.java

@@ -96,7 +96,7 @@ private void validateIdsAndDocs(List<String> ids, List<SpecifiedDocument> docs)
         boolean validIds = ids != null && ids.isEmpty() == false;
         boolean validDocs = docs != null && docs.isEmpty() == false;
 
-        if (!validIds && !validDocs) {
+        if (validIds == false && validDocs == false) {
             throw new IllegalArgumentException("Either 'ids' or 'docs' must be provided and non-empty for pinned retriever");
         }
     }