Skip to content

Commit deb793e

Browse files
authored
Unmute FollowingEngineTests#testProcessOnceOnPrimary() test (#129054)
The reason the test fails is that operations contained _seq_no field with different doc value types (with no skippers and with skippers) and this isn't allowed, since field types need to be consistent in a Lucene index. The initial operations were generated not knowing about the fact the index mode was set to logsdb or time_series. Causing the operations to not have doc value skippers. However when replaying the operations via following engine, the operations did have doc value skippers. The fix is to set `index.seq_no.index_options` to `points_and_doc_values`, so that the initial operations are indexed without doc value skippers. This test doesn't gain anything from storing seqno with doc value skippers, so there is no loss of testing coverage. Closes #128541
1 parent fa383af commit deb793e

File tree

2 files changed

+2
-3
lines changed

2 files changed

+2
-3
lines changed

muted-tests.yml

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -495,9 +495,6 @@ tests:
495495
- class: org.elasticsearch.xpack.inference.InferenceGetServicesIT
496496
method: testGetServicesWithCompletionTaskType
497497
issue: https://github.com/elastic/elasticsearch/issues/128952
498-
- class: org.elasticsearch.xpack.ccr.index.engine.FollowingEngineTests
499-
method: testProcessOnceOnPrimary
500-
issue: https://github.com/elastic/elasticsearch/issues/128541
501498
- class: org.elasticsearch.packaging.test.DockerTests
502499
method: test073RunEsAsDifferentUserAndGroupWithoutBindMounting
503500
issue: https://github.com/elastic/elasticsearch/issues/128996

x-pack/plugin/ccr/src/test/java/org/elasticsearch/xpack/ccr/index/engine/FollowingEngineTests.java

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -771,9 +771,11 @@ public void testProcessOnceOnPrimary() throws Exception {
771771
break;
772772
case TIME_SERIES:
773773
settingsBuilder.put("index.mode", "time_series").put("index.routing_path", "foo");
774+
settingsBuilder.put("index.seq_no.index_options", "points_and_doc_values");
774775
break;
775776
case LOGSDB:
776777
settingsBuilder.put("index.mode", IndexMode.LOGSDB.getName());
778+
settingsBuilder.put("index.seq_no.index_options", "points_and_doc_values");
777779
break;
778780
case LOOKUP:
779781
settingsBuilder.put("index.mode", IndexMode.LOOKUP.getName());

0 commit comments

Comments
 (0)