Fix IndexFoldersDeletionListenerIT#testListenersInvokedWhenIndexIsDangling (#111440) (#118264)

arteam · nicktindall · web-flow · commit df7ebe7fa517 · 2024-12-10T10:06:29.000+01:00
Closes #111192 Co-authored-by: Nick Tindall <nick.tindall@elastic.co>
diff --git a/server/src/internalClusterTest/java/org/elasticsearch/plugins/IndexFoldersDeletionListenerIT.java b/server/src/internalClusterTest/java/org/elasticsearch/plugins/IndexFoldersDeletionListenerIT.java
@@ -350,7 +350,7 @@ public void beforeIndexFoldersDeleted(Index index, IndexSettings indexSettings,
 
                 @Override
                 public void beforeShardFoldersDeleted(ShardId shardId, IndexSettings indexSettings, Path[] shardPaths) {
-                    deletedShards.computeIfAbsent(shardId.getIndex(), i -> new ArrayList<>()).add(shardId);
+                    deletedShards.computeIfAbsent(shardId.getIndex(), i -> Collections.synchronizedList(new ArrayList<>())).add(shardId);
                 }
             });
         }

Original file line number	Diff line number	Diff line change
`@@ -350,7 +350,7 @@ public void beforeIndexFoldersDeleted(Index index, IndexSettings indexSettings,`
`350`	`350`
`351`	`351`	`@Override`
`352`	`352`	`public void beforeShardFoldersDeleted(ShardId shardId, IndexSettings indexSettings, Path[] shardPaths) {`
`353`		`- deletedShards.computeIfAbsent(shardId.getIndex(), i -> new ArrayList<>()).add(shardId);`
	`353`	`+ deletedShards.computeIfAbsent(shardId.getIndex(), i -> Collections.synchronizedList(new ArrayList<>())).add(shardId);`
`354`	`354`	`}`
`355`	`355`	`});`
`356`	`356`	`}`