Skip to content

Commit dfa1fc4

Browse files
Fix SearchResponse leak in CrossClusterSearchUnavailableClusterIT (#121681) (#121696)
Fixing an obvious leak where we fail to count down 1 for a new search response.
1 parent d0fde6d commit dfa1fc4

File tree

1 file changed

+9
-4
lines changed

1 file changed

+9
-4
lines changed

qa/ccs-unavailable-clusters/src/javaRestTest/java/org/elasticsearch/search/CrossClusterSearchUnavailableClusterIT.java

Lines changed: 9 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -101,8 +101,8 @@ private static MockTransportService startTransport(
101101
TransportSearchAction.TYPE.name(),
102102
EsExecutors.DIRECT_EXECUTOR_SERVICE,
103103
SearchRequest::new,
104-
(request, channel, task) -> channel.sendResponse(
105-
new SearchResponse(
104+
(request, channel, task) -> {
105+
var searchResponse = new SearchResponse(
106106
SearchHits.empty(new TotalHits(0, TotalHits.Relation.EQUAL_TO), Float.NaN),
107107
InternalAggregations.EMPTY,
108108
null,
@@ -117,8 +117,13 @@ private static MockTransportService startTransport(
117117
100,
118118
ShardSearchFailure.EMPTY_ARRAY,
119119
SearchResponse.Clusters.EMPTY
120-
)
121-
)
120+
);
121+
try {
122+
channel.sendResponse(searchResponse);
123+
} finally {
124+
searchResponse.decRef();
125+
}
126+
}
122127
);
123128
newService.registerRequestHandler(
124129
ClusterStateAction.NAME,

0 commit comments

Comments
 (0)