Skip to content

Commit e00abb5

Browse files
committed
review feedback
1 parent 61fe122 commit e00abb5

File tree

2 files changed

+2
-6
lines changed
  • x-pack/plugin/esql/src/main/java/org/elasticsearch/xpack/esql/plan/logical

2 files changed

+2
-6
lines changed

x-pack/plugin/esql/src/main/java/org/elasticsearch/xpack/esql/plan/logical/Fork.java

Lines changed: 1 addition & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -33,12 +33,7 @@
3333
* A Fork is a n-ary {@code Plan} where each child is a sub plan, e.g.
3434
* {@code FORK [WHERE content:"fox" ] [WHERE content:"dog"] }
3535
*/
36-
public class Fork extends LogicalPlan
37-
implements
38-
PostAnalysisPlanVerificationAware,
39-
TelemetryAware,
40-
PipelineBreaker,
41-
ExecutesOn.Coordinator {
36+
public class Fork extends LogicalPlan implements PostAnalysisPlanVerificationAware, TelemetryAware, ExecutesOn.Coordinator {
4237

4338
public static final String FORK_FIELD = "_fork";
4439
public static final int MAX_BRANCHES = 8;

x-pack/plugin/esql/src/main/java/org/elasticsearch/xpack/esql/plan/logical/join/Join.java

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -331,6 +331,7 @@ private void checkRemoteJoin(Failures failures) {
331331
}
332332
if (u instanceof Limit) {
333333
// Limit is ok because it can be moved in by the optimizer
334+
// We check LIMITs in LookupJoin pre-optimization so they are still not allowed there
334335
return;
335336
}
336337
if (u instanceof PipelineBreaker || (u instanceof ExecutesOn ex && ex.executesOn() == ExecuteLocation.COORDINATOR)) {

0 commit comments

Comments
 (0)