Skip to content

Commit e24e33d

Browse files
Remove Inject
1 parent a7d96ca commit e24e33d

File tree

5 files changed

+23
-15
lines changed

5 files changed

+23
-15
lines changed

x-pack/plugin/gpu/src/internalClusterTest/java/org/elasticsearch/xpack/gpu/GPUIndexIT.java

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,6 @@
1212
import org.elasticsearch.action.bulk.BulkResponse;
1313
import org.elasticsearch.common.settings.Settings;
1414
import org.elasticsearch.gpu.GPUSupport;
15-
import org.elasticsearch.injection.guice.Inject;
1615
import org.elasticsearch.plugins.Plugin;
1716
import org.elasticsearch.search.SearchHit;
1817
import org.elasticsearch.search.vectors.ExactKnnQueryBuilder;
@@ -37,9 +36,8 @@
3736
public class GPUIndexIT extends ESIntegTestCase {
3837

3938
public static class TestGPUPlugin extends GPUPlugin {
40-
@Inject
41-
public TestGPUPlugin(Settings settings) {
42-
super(Settings.builder().put(settings).put("vectors.indexing.use_gpu", GpuMode.TRUE.name()).build());
39+
public TestGPUPlugin() {
40+
super(Settings.builder().put("vectors.indexing.use_gpu", GpuMode.TRUE.name()).build());
4341
}
4442

4543
@Override

x-pack/plugin/gpu/src/internalClusterTest/java/org/elasticsearch/xpack/gpu/GPUPluginInitializationUnsupportedIT.java

Lines changed: 9 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,7 @@
77

88
package org.elasticsearch.xpack.gpu;
99

10+
import org.elasticsearch.common.settings.Settings;
1011
import org.elasticsearch.index.IndexService;
1112
import org.elasticsearch.index.IndexSettings;
1213
import org.elasticsearch.index.mapper.vectors.DenseVectorFieldTypeTests;
@@ -27,15 +28,21 @@ public class GPUPluginInitializationUnsupportedIT extends ESIntegTestCase {
2728
TestCuVSServiceProvider.mockedGPUInfoProvider = p -> { throw new UnsupportedOperationException("cuvs-java UnsupportedProvider"); };
2829
}
2930

31+
public static class TestGPUPlugin extends GPUPlugin {
32+
public TestGPUPlugin() {
33+
super(Settings.EMPTY);
34+
}
35+
}
36+
3037
@Override
3138
protected Collection<Class<? extends Plugin>> nodePlugins() {
32-
return List.of(GPUPlugin.class);
39+
return List.of(TestGPUPlugin.class);
3340
}
3441

3542
public void testAutoModeWithUnavailableGPU() {
3643
assumeTrue("GPU_FORMAT feature flag enabled", GPUPlugin.GPU_FORMAT.isEnabled());
3744

38-
GPUPlugin gpuPlugin = internalCluster().getInstance(GPUPlugin.class);
45+
TestGPUPlugin gpuPlugin = internalCluster().getInstance(TestGPUPlugin.class);
3946
VectorsFormatProvider vectorsFormatProvider = gpuPlugin.getVectorsFormatProvider();
4047

4148
createIndex("index1");

x-pack/plugin/gpu/src/internalClusterTest/java/org/elasticsearch/xpack/gpu/GPUPluginInitializationWithGPUIT.java

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,6 @@
1616
import org.elasticsearch.index.mapper.vectors.DenseVectorFieldTypeTests;
1717
import org.elasticsearch.index.mapper.vectors.VectorsFormatProvider;
1818
import org.elasticsearch.indices.IndicesService;
19-
import org.elasticsearch.injection.guice.Inject;
2019
import org.elasticsearch.plugins.Plugin;
2120
import org.elasticsearch.test.ESIntegTestCase;
2221
import org.junit.After;
@@ -49,9 +48,8 @@ public class GPUPluginInitializationWithGPUIT extends ESIntegTestCase {
4948

5049
public static class TestGPUPlugin extends GPUPlugin {
5150

52-
@Inject
53-
public TestGPUPlugin(Settings settings) {
54-
super(Settings.builder().put(settings).put("vectors.indexing.use_gpu", gpuMode.name()).build());
51+
public TestGPUPlugin() {
52+
super(Settings.builder().put("vectors.indexing.use_gpu", gpuMode.name()).build());
5553
}
5654

5755
@Override

x-pack/plugin/gpu/src/internalClusterTest/java/org/elasticsearch/xpack/gpu/GPUPluginInitializationWithoutGPUIT.java

Lines changed: 10 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,7 @@
77

88
package org.elasticsearch.xpack.gpu;
99

10+
import org.elasticsearch.common.settings.Settings;
1011
import org.elasticsearch.index.IndexService;
1112
import org.elasticsearch.index.IndexSettings;
1213
import org.elasticsearch.index.mapper.vectors.DenseVectorFieldTypeTests;
@@ -26,15 +27,21 @@ public class GPUPluginInitializationWithoutGPUIT extends ESIntegTestCase {
2627
TestCuVSServiceProvider.mockedGPUInfoProvider = p -> new TestCuVSServiceProvider.TestGPUInfoProvider(List.of());
2728
}
2829

30+
public static class TestGPUPlugin extends GPUPlugin {
31+
public TestGPUPlugin() {
32+
super(Settings.EMPTY);
33+
}
34+
}
35+
2936
@Override
3037
protected Collection<Class<? extends Plugin>> nodePlugins() {
31-
return List.of(GPUPlugin.class);
38+
return List.of(TestGPUPlugin.class);
3239
}
3340

3441
public void testFFOff() {
3542
assumeFalse("GPU_FORMAT feature flag disabled", GPUPlugin.GPU_FORMAT.isEnabled());
3643

37-
GPUPlugin gpuPlugin = internalCluster().getInstance(GPUPlugin.class);
44+
TestGPUPlugin gpuPlugin = internalCluster().getInstance(TestGPUPlugin.class);
3845
VectorsFormatProvider vectorsFormatProvider = gpuPlugin.getVectorsFormatProvider();
3946

4047
var format = vectorsFormatProvider.getKnnVectorsFormat(null, null, null);
@@ -44,7 +51,7 @@ public void testFFOff() {
4451
public void testAutoModeWithoutGPU() {
4552
assumeTrue("GPU_FORMAT feature flag enabled", GPUPlugin.GPU_FORMAT.isEnabled());
4653

47-
GPUPlugin gpuPlugin = internalCluster().getInstance(GPUPlugin.class);
54+
TestGPUPlugin gpuPlugin = internalCluster().getInstance(TestGPUPlugin.class);
4855
VectorsFormatProvider vectorsFormatProvider = gpuPlugin.getVectorsFormatProvider();
4956

5057
createIndex("index1");

x-pack/plugin/gpu/src/main/java/org/elasticsearch/xpack/gpu/GPUPlugin.java

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,6 @@
1919
import org.elasticsearch.gpu.codec.ES92GpuHnswVectorsFormat;
2020
import org.elasticsearch.index.mapper.vectors.DenseVectorFieldMapper;
2121
import org.elasticsearch.index.mapper.vectors.VectorsFormatProvider;
22-
import org.elasticsearch.injection.guice.Inject;
2322
import org.elasticsearch.license.License;
2423
import org.elasticsearch.plugins.Plugin;
2524
import org.elasticsearch.plugins.internal.InternalVectorFormatProviderPlugin;
@@ -35,7 +34,6 @@ public class GPUPlugin extends Plugin implements InternalVectorFormatProviderPlu
3534

3635
private final GpuMode gpuMode;
3736

38-
@Inject
3937
public GPUPlugin(Settings settings) {
4038
this.gpuMode = VECTORS_INDEXING_USE_GPU_NODE_SETTING.get(settings);
4139
}

0 commit comments

Comments
 (0)