Skip to content

Commit e3259d9

Browse files
committed
Fix error in docId calculation
1 parent e6208ec commit e3259d9

File tree

1 file changed

+4
-3
lines changed

1 file changed

+4
-3
lines changed

x-pack/plugin/inference/src/main/java/org/elasticsearch/xpack/inference/rank/textsimilarity/TextSimilarityRankFeaturePhaseRankCoordinatorContext.java

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -216,8 +216,9 @@ private float[] extractScoresFromRankedSnippets(List<RankedDocsResults.RankedDoc
216216

217217
for (int i = 0; i < rankedDocs.size(); i++) {
218218
// TODO this naively assumes that we always get the requested number of snippets per ranked document
219-
int docId = i / numSnippets;
220-
float score = rankedDocs.get(i).relevanceScore();
219+
RankedDocsResults.RankedDoc rankedDoc = rankedDocs.get(i);
220+
int docId = rankedDoc.index() / numSnippets;
221+
float score = rankedDoc.relevanceScore();
221222

222223
if (hasScore[docId] == false) {
223224
scores[docId] = score;
@@ -229,7 +230,7 @@ private float[] extractScoresFromRankedSnippets(List<RankedDocsResults.RankedDoc
229230

230231
float[] result = new float[featureDocs.length];
231232
for (int i = 0; i < featureDocs.length; i++) {
232-
result[i] = hasScore[i] ? normalizeScore(scores[i]) : 0f;
233+
result[i] = hasScore[i] ? scores[i] : 0f;
233234
}
234235

235236
return result;

0 commit comments

Comments
 (0)