test checks

Author: pabloem

x-pack/plugin/esql/qa/testFixtures/src/main/resources/math.csv-spec

@@ -1844,13 +1844,26 @@ emp_no:integer | l1:double | l2:double
 ;
 
 copySignWithMixedNumericValues
+required_capability: mixed_numeric_types_in_case_copy_sign
+
+ROW cs1=COPY_SIGN(10.0, -5.0), cs2=COPY_SIGN(10.0, null);
+
+cs1:double | cs2:double
+-5.0       | null
+;
+
+copySignWithMixedNumericValuesWithMV
 required_capability: mixed_numeric_types_in_case_greatest_least
 
-ROW a = 1.0, b = -2.0
-| EVAL c = copy_sign(a, b)
-| EVAL d = copy_sign(b, a)
+FROM employees
+| EVAL cs1 = COPY_SIGN(salary, salary_change)
+| KEEP emp_no, salary, salary_change, cs1
+| SORT emp_no
+| LIMIT 3
 ;
 
-a:double | b:double | c:double | d:double
-1.0      | -2.0     | -1.0     | 2.0
+emp_no:integer | salary:long | salary_change:double | cs1:double
+10001          | 57305       | 1.19                | 57305
+10002          | 56371       | -7.23               | -56371
+10003          | 61805       | 4.0                 | 61805
 ;

x-pack/plugin/esql/src/main/java/org/elasticsearch/xpack/esql/expression/function/scalar/math/CopySign.java

@@ -65,12 +65,12 @@ public CopySign(
         Source source,
         @Param(
             name = "magnitude",
-            type = { "double", "float" },
+            type = { "double", "float", "integer", "long" },
             description = "The expression providing the magnitude of the result. Must be a numeric type."
         ) Expression magnitude,
         @Param(
             name = "sign",
-            type = { "double", "float" },
+            type = { "double", "float", "integer", "long" },
             description = "The expression providing the sign of the result. Must be a numeric type."
         ) Expression sign
     ) {
@@ -122,24 +122,31 @@ public TypeResolution resolveType() {
         }
         var magnitude = children().get(0);
         var sign = children().get(1);
-        if (magnitude.dataType().isNumeric() == false || magnitude.dataType().isRationalNumber() == false) {
-            return new TypeResolution("Magnitude must be a float or double type");
+        if (magnitude.dataType().isNumeric() == false) {
+            return new TypeResolution("Magnitude must be a numeric type");
         }
-        if (sign.dataType().isNumeric() == false || sign.dataType().isRationalNumber() == false) {
-            return new TypeResolution("Sign must be a float or double type");
+        if (sign.dataType().isNumeric() == false) {
+            return new TypeResolution("Sign must be a numeric type");
         }
-        var commonType = EsqlDataTypeConverter.commonType(magnitude.dataType(), sign.dataType());
-        TypeResolution resolution = TypeResolutions.isType(
-            magnitude,
-            t -> t == commonType,
-            sourceText(),
-            TypeResolutions.ParamOrdinal.fromIndex(1),
-            magnitude.dataType().typeName()
-        );
-        if (resolution.unresolved()) {
-            return resolution;
-        }
-        dataType = commonType;
+        dataType = EsqlDataTypeConverter.commonType(magnitude.dataType(), sign.dataType());
+//        TypeResolution resolution = TypeResolutions.isType(
+//            magnitude,
+//            t -> t == commonType,
+//            sourceText(),
+//            TypeResolutions.ParamOrdinal.fromIndex(1),
+//            magnitude.dataType().typeName()
+//        );
+//        if (resolution.unresolved()) {
+//            throw new EsqlIllegalArgumentException(
+//                "Magnitude [{}] is not compatible with sign [{}] for function [{}] - common type is [{}]",
+//                magnitude.dataType(),
+//                sign.dataType(),
+//                NAME
+//                ,commonType
+//            );
+////            return resolution;
+//        }
+//        dataType = commonType;
         return TypeResolution.TYPE_RESOLVED;
     }
 
@@ -168,4 +175,21 @@ static float processFloat(float magnitude, float sign) {
     static double processDouble(double magnitude, double sign) {
         return Math.copySign(magnitude, sign);
     }
+
+    @Evaluator(extraName = "Long")
+    static long processLong(long magnitude, long sign) {
+        if (sign < 0) {
+            return -Math.abs(magnitude);
+        } else {
+            return Math.abs(magnitude);
+        }
+    }
+    @Evaluator(extraName = "Integer")
+    static int processInteger(int magnitude, int sign) {
+        if (sign < 0) {
+            return -Math.abs(magnitude);
+        } else {
+            return Math.abs(magnitude);
+        }
+    }
 }