Fix naming, some pedantry

Author: nicktindall

server/src/main/java/org/elasticsearch/cluster/routing/allocation/allocator/DesiredBalanceMetrics.java

@@ -61,7 +61,7 @@ public long undesiredAllocationsExcludingShuttingDownNodes() {
          * @return a value in [0.0, 1.0]
          */
         public double undesiredAllocationsRatio() {
-            long totalAllocations = totalAllocations();
+            final long totalAllocations = totalAllocations();
             if (totalAllocations == 0) {
                 return 0;
             }
@@ -256,7 +256,7 @@ public long undesiredAllocations() {
         return lastReconciliationAllocationStats.undesiredAllocationsExcludingShuttingDownNodes();
     }
 
-    public AllocationStats allocationStatsByRole() {
+    public AllocationStats allocationStats() {
         return lastReconciliationAllocationStats;
     }
 

server/src/main/java/org/elasticsearch/cluster/routing/allocation/allocator/DesiredBalanceShardsAllocator.java

@@ -438,8 +438,8 @@ public DesiredBalanceStats getStats() {
         );
     }
 
-    public DesiredBalanceMetrics.AllocationStats getAllocationStatsByRole() {
-        return desiredBalanceMetrics.allocationStatsByRole();
+    public DesiredBalanceMetrics.AllocationStats getAllocationStats() {
+        return desiredBalanceMetrics.allocationStats();
     }
 
     private void onNoLongerMaster() {