Ensure enough nodes in WriteLoadForecasterIT (#134206)

DaveCTurner · web-flow · commit e5aea7bdf500 · 2025-09-05T12:27:29.000+02:00
These tests would sometimes create 1-replica indices in a 1-node cluster which will never reach `green` health. This commit ensures there are enough nodes to allocate all the shards. Closes #133455 Closes #134124 Closes #134123 Backport of #134132 and #134099 to `9.0`
diff --git a/x-pack/plugin/write-load-forecaster/src/internalClusterTest/java/org/elasticsearch/xpack/writeloadforecaster/WriteLoadForecasterIT.java b/x-pack/plugin/write-load-forecaster/src/internalClusterTest/java/org/elasticsearch/xpack/writeloadforecaster/WriteLoadForecasterIT.java
@@ -145,6 +145,8 @@ private void setUpDataStreamWriteDocsAndRollover(String dataStreamName) throws E
     private void setUpDataStreamWriteDocsAndRollover(String dataStreamName, Settings extraIndexTemplateSettings) throws Exception {
         final int numberOfShards = randomIntBetween(1, 5);
         final int numberOfReplicas = randomIntBetween(0, 1);
+        internalCluster().ensureAtLeastNumDataNodes(numberOfReplicas + 1);
+
         final Settings indexSettings = Settings.builder()
             .put(extraIndexTemplateSettings)
             .put(IndexMetadata.SETTING_NUMBER_OF_SHARDS, numberOfShards)
@@ -194,6 +196,7 @@ private void setUpDataStreamWriteDocsAndRollover(String dataStreamName, Settings
 
             assertAcked(indicesAdmin().rolloverIndex(new RolloverRequest(dataStreamName, null)).actionGet());
         }
+        ensureGreen();
     }
 
     static void indexDocs(String dataStream, int numDocs) {

Original file line number	Diff line number	Diff line change
`@@ -145,6 +145,8 @@ private void setUpDataStreamWriteDocsAndRollover(String dataStreamName) throws E`
`145`	`145`	`private void setUpDataStreamWriteDocsAndRollover(String dataStreamName, Settings extraIndexTemplateSettings) throws Exception {`
`146`	`146`	`final int numberOfShards = randomIntBetween(1, 5);`
`147`	`147`	`final int numberOfReplicas = randomIntBetween(0, 1);`
	`148`	`+ internalCluster().ensureAtLeastNumDataNodes(numberOfReplicas + 1);`
	`149`	`+`
`148`	`150`	`final Settings indexSettings = Settings.builder()`
`149`	`151`	`.put(extraIndexTemplateSettings)`
`150`	`152`	`.put(IndexMetadata.SETTING_NUMBER_OF_SHARDS, numberOfShards)`
`@@ -194,6 +196,7 @@ private void setUpDataStreamWriteDocsAndRollover(String dataStreamName, Settings`
`194`	`196`
`195`	`197`	`assertAcked(indicesAdmin().rolloverIndex(new RolloverRequest(dataStreamName, null)).actionGet());`
`196`	`198`	`}`
	`199`	`+ ensureGreen();`
`197`	`200`	`}`
`198`	`201`
`199`	`202`	`static void indexDocs(String dataStream, int numDocs) {`