iter

javanna · javanna · commit e60e08b3f67c · 2025-02-27T15:28:00.000+01:00
diff --git a/server/src/test/java/org/elasticsearch/search/builder/SearchSourceBuilderTests.java b/server/src/test/java/org/elasticsearch/search/builder/SearchSourceBuilderTests.java
@@ -996,17 +996,27 @@ public void testSupportsParallelCollection() {
         }
         {
             SearchSourceBuilder searchSourceBuilder = newSearchSourceBuilder.get();
-            searchSourceBuilder.aggregation(new TopHitsAggregationBuilder("terms"));
+            searchSourceBuilder.aggregation(new TopHitsAggregationBuilder("tophits"));
             assertTrue(searchSourceBuilder.supportsParallelCollection(fieldCardinality));
         }
         {
             SearchSourceBuilder searchSourceBuilder = newSearchSourceBuilder.get();
-            searchSourceBuilder.aggregation(new TopHitsAggregationBuilder("terms").sort("_score"));
+            searchSourceBuilder.aggregation(new TopHitsAggregationBuilder("tophits").sort("_score"));
             assertTrue(searchSourceBuilder.supportsParallelCollection(fieldCardinality));
         }
         {
             SearchSourceBuilder searchSourceBuilder = newSearchSourceBuilder.get();
-            searchSourceBuilder.aggregation(new TopHitsAggregationBuilder("terms").sort(SortBuilders.fieldSort("field")));
+            searchSourceBuilder.aggregation(new TopHitsAggregationBuilder("tophits").sort(SortBuilders.fieldSort("field")));
+            assertFalse(searchSourceBuilder.supportsParallelCollection(fieldCardinality));
+        }
+        {
+            SearchSourceBuilder searchSourceBuilder = newSearchSourceBuilder.get();
+            searchSourceBuilder.aggregation(new TermsAggregationBuilder("terms").subAggregation(new TopHitsAggregationBuilder("tophits")));
+            assertFalse(searchSourceBuilder.supportsParallelCollection(fieldCardinality));
+        }
+        {
+            SearchSourceBuilder searchSourceBuilder = newSearchSourceBuilder.get();
+            searchSourceBuilder.aggregation(new TopHitsAggregationBuilder("tophits").subAggregation(new TermsAggregationBuilder("terms") ));
             assertFalse(searchSourceBuilder.supportsParallelCollection(fieldCardinality));
         }
         {

Original file line number	Diff line number	Diff line change
`@@ -996,17 +996,27 @@ public void testSupportsParallelCollection() {`
`996`	`996`	`}`
`997`	`997`	`{`
`998`	`998`	`SearchSourceBuilder searchSourceBuilder = newSearchSourceBuilder.get();`
`999`		`- searchSourceBuilder.aggregation(new TopHitsAggregationBuilder("terms"));`
	`999`	`+ searchSourceBuilder.aggregation(new TopHitsAggregationBuilder("tophits"));`
`1000`	`1000`	`assertTrue(searchSourceBuilder.supportsParallelCollection(fieldCardinality));`
`1001`	`1001`	`}`
`1002`	`1002`	`{`
`1003`	`1003`	`SearchSourceBuilder searchSourceBuilder = newSearchSourceBuilder.get();`
`1004`		`- searchSourceBuilder.aggregation(new TopHitsAggregationBuilder("terms").sort("_score"));`
	`1004`	`+ searchSourceBuilder.aggregation(new TopHitsAggregationBuilder("tophits").sort("_score"));`
`1005`	`1005`	`assertTrue(searchSourceBuilder.supportsParallelCollection(fieldCardinality));`
`1006`	`1006`	`}`
`1007`	`1007`	`{`
`1008`	`1008`	`SearchSourceBuilder searchSourceBuilder = newSearchSourceBuilder.get();`
`1009`		`- searchSourceBuilder.aggregation(new TopHitsAggregationBuilder("terms").sort(SortBuilders.fieldSort("field")));`
	`1009`	`+ searchSourceBuilder.aggregation(new TopHitsAggregationBuilder("tophits").sort(SortBuilders.fieldSort("field")));`
	`1010`	`+ assertFalse(searchSourceBuilder.supportsParallelCollection(fieldCardinality));`
	`1011`	`+ }`
	`1012`	`+ {`
	`1013`	`+ SearchSourceBuilder searchSourceBuilder = newSearchSourceBuilder.get();`
	`1014`	`+ searchSourceBuilder.aggregation(new TermsAggregationBuilder("terms").subAggregation(new TopHitsAggregationBuilder("tophits")));`
	`1015`	`+ assertFalse(searchSourceBuilder.supportsParallelCollection(fieldCardinality));`
	`1016`	`+ }`
	`1017`	`+ {`
	`1018`	`+ SearchSourceBuilder searchSourceBuilder = newSearchSourceBuilder.get();`
	`1019`	`+ searchSourceBuilder.aggregation(new TopHitsAggregationBuilder("tophits").subAggregation(new TermsAggregationBuilder("terms") ));`
`1010`	`1020`	`assertFalse(searchSourceBuilder.supportsParallelCollection(fieldCardinality));`
`1011`	`1021`	`}`
`1012`	`1022`	`{`