ESQL: Unmute MedianAbsoluteDeviationDoubleGroupingAggregatorFunctionTests testMulitvaluedNullGroup (#109942)

alex-spies · web-flow · commit e79ee173b2c5 · 2024-06-20T14:38:20.000+02:00
Already fixed in #100556.
diff --git a/x-pack/plugin/esql/compute/src/test/java/org/elasticsearch/compute/aggregation/GroupingAggregatorFunctionTestCase.java b/x-pack/plugin/esql/compute/src/test/java/org/elasticsearch/compute/aggregation/GroupingAggregatorFunctionTestCase.java
@@ -276,7 +276,7 @@ public final void testMulitvaluedNullGroupsAndValues() {
         assertSimpleOutput(origInput, results);
     }
 
-    public void testMulitvaluedNullGroup() {
+    public final void testMulitvaluedNullGroup() {
         DriverContext driverContext = driverContext();
         BlockFactory blockFactory = driverContext.blockFactory();
         int end = between(1, 2);  // TODO revert
diff --git a/x-pack/plugin/esql/compute/src/test/java/org/elasticsearch/compute/aggregation/MedianAbsoluteDeviationDoubleGroupingAggregatorFunctionTests.java b/x-pack/plugin/esql/compute/src/test/java/org/elasticsearch/compute/aggregation/MedianAbsoluteDeviationDoubleGroupingAggregatorFunctionTests.java
@@ -76,9 +76,4 @@ static double median(DoubleStream s) {
         int c = data.length / 2;
         return data.length % 2 == 0 ? (data[c - 1] + data[c]) / 2 : data[c];
     }
-
-    @AwaitsFix(bugUrl = "https://github.com/elastic/elasticsearch/issues/101569")
-    public void testMulitvaluedNullGroup() {
-        // only here for muting it
-    }
 }

Original file line number	Diff line number	Diff line change
`@@ -276,7 +276,7 @@ public final void testMulitvaluedNullGroupsAndValues() {`
`276`	`276`	`assertSimpleOutput(origInput, results);`
`277`	`277`	`}`
`278`	`278`
`279`		`- public void testMulitvaluedNullGroup() {`
	`279`	`+ public final void testMulitvaluedNullGroup() {`
`280`	`280`	`DriverContext driverContext = driverContext();`
`281`	`281`	`BlockFactory blockFactory = driverContext.blockFactory();`
`282`	`282`	`int end = between(1, 2); // TODO revert`
Original file line number	Diff line number	Diff line change
`@@ -76,9 +76,4 @@ static double median(DoubleStream s) {`
`76`	`76`	`int c = data.length / 2;`
`77`	`77`	`return data.length % 2 == 0 ? (data[c - 1] + data[c]) / 2 : data[c];`
`78`	`78`	`}`
`79`		`-`
`80`		`- @AwaitsFix(bugUrl = "https://github.com/elastic/elasticsearch/issues/101569")`
`81`		`- public void testMulitvaluedNullGroup() {`
`82`		`- // only here for muting it`
`83`		`- }`
`84`	`79`	`}`