Move some deprecation warnings to critical (#116969)

* Move some deprecation warnings to critical

* Fix tests

* Fix another test

* Leave Fractional Bytes as warn for now.

There's more going on with this one. Let's leave it alone and hand it in its own PR.

Author: prdoyle

server/src/main/java/org/elasticsearch/common/time/DateUtils.java

@@ -170,7 +170,7 @@ public class DateUtils {
     public static ZoneId of(String zoneId) {
         String deprecatedId = DEPRECATED_SHORT_TIMEZONES.get(zoneId);
         if (deprecatedId != null) {
-            deprecationLogger.warn(
+            deprecationLogger.critical(
                 DeprecationCategory.PARSING,
                 "timezone",
                 "Use of short timezone id " + zoneId + " is deprecated. Use " + deprecatedId + " instead"

server/src/main/java/org/elasticsearch/common/unit/MemorySizeValue.java

@@ -59,10 +59,10 @@ private static ByteSizeValue parseHeapRatio(String sValue, String settingName, d
                 throw new ElasticsearchParseException("percentage should be in [0-100], got [{}]", percentAsString);
             } else if (percent < minHeapPercent) {
                 DeprecationLogger.getLogger(MemorySizeValue.class)
-                    .warn(
+                    .critical(
                         DeprecationCategory.SETTINGS,
                         "memory_size_below_minimum",
-                        "[{}] setting of [{}] is below the recommended minimum of {}% of the heap",
+                        "[{}] setting of [{}] is below the minimum of {}% of the heap",
                         settingName,
                         sValue,
                         minHeapPercent

server/src/test/java/org/elasticsearch/common/settings/MemorySizeSettingsTests.java

@@ -72,8 +72,8 @@ public void testCircuitBreakerSettings() {
             "indices.breaker.total.limit",
             ByteSizeValue.ofBytes((long) (JvmInfo.jvmInfo().getMem().getHeapMax().getBytes() * defaultTotalPercentage))
         );
-        assertWarnings(
-            "[indices.breaker.total.limit] setting of [25%] is below the recommended minimum of 50.0% of the heap",
+        assertCriticalWarnings(
+            "[indices.breaker.total.limit] setting of [25%] is below the minimum of 50.0% of the heap",
             "[indices.breaker.total.limit] should be specified using a percentage of the heap. "
                 + "Absolute size settings will be forbidden in a future release"
         );

server/src/test/java/org/elasticsearch/indices/breaker/HierarchyCircuitBreakerServiceTests.java

@@ -877,7 +877,7 @@ public void testSizeBelowMinimumWarning() {
             HierarchyCircuitBreakerService.TOTAL_CIRCUIT_BREAKER_LIMIT_SETTING.getKey(),
             20
         );
-        assertWarnings("[indices.breaker.total.limit] setting of [19%] is below the recommended minimum of 20.0% of the heap");
+        assertCriticalWarnings("[indices.breaker.total.limit] setting of [19%] is below the minimum of 20.0% of the heap");
     }
 
     public void testBuildParentTripMessage() {

x-pack/plugin/eql/src/test/java/org/elasticsearch/xpack/eql/execution/sequence/CircuitBreakerTests.java

@@ -303,7 +303,7 @@ public void testEqlCBCleanedUp_on_ParentCBBreak() {
             );
             window.execute(wrap(p -> fail(), ex -> assertTrue(ex instanceof CircuitBreakingException)));
         }
-        assertCriticalWarnings("[indices.breaker.total.limit] setting of [0%] is below the recommended minimum of 50.0% of the heap");
+        assertCriticalWarnings("[indices.breaker.total.limit] setting of [0%] is below the minimum of 50.0% of the heap");
     }
 
     private List<BreakerSettings> breakerSettings() {