[8.x] Simplify InternalOrder.isOrder a little (#122372) (#122393)

* Simplify InternalOrder.isOrder a little (#122372)

No need for recursion here. We don't allow nested compound order instances
so this thing works exactly as the JavaDoc states and we only need to check
one level down.

* update after review

---------

Co-authored-by: Dimitris Rempapis <[email protected]>

Author: original-brownbear

server/src/main/java/org/elasticsearch/search/aggregations/InternalOrder.java

@@ -440,16 +440,7 @@ public static boolean isKeyDesc(BucketOrder order) {
      * @return {@code true} if the order matches, {@code false} otherwise.
      */
     private static boolean isOrder(BucketOrder order, BucketOrder expected) {
-        if (order == expected) {
-            return true;
-        } else if (order instanceof CompoundOrder) {
-            // check if its a compound order with the first element that matches
-            List<BucketOrder> orders = ((CompoundOrder) order).orderElements;
-            if (orders.size() >= 1) {
-                return isOrder(orders.get(0), expected);
-            }
-        }
-        return false;
+        return order == expected || (order instanceof CompoundOrder compoundOrder && compoundOrder.orderElements.get(0) == expected);
     }
 
     /**