Skip to content

Commit e934600

Browse files
Fix testMergeSourceWithFollowUpMergesRunSequentially (#126050)
Fixes #125639 Relates #120869
1 parent eb4d64f commit e934600

File tree

2 files changed

+4
-5
lines changed

2 files changed

+4
-5
lines changed

muted-tests.yml

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -320,9 +320,6 @@ tests:
320320
- class: org.elasticsearch.smoketest.MlWithSecurityIT
321321
method: test {yaml=ml/data_frame_analytics_crud/Test get stats on newly created config}
322322
issue: https://github.com/elastic/elasticsearch/issues/121726
323-
- class: org.elasticsearch.index.engine.ThreadPoolMergeSchedulerTests
324-
method: testMergeSourceWithFollowUpMergesRunSequentially
325-
issue: https://github.com/elastic/elasticsearch/issues/125639
326323
- class: org.elasticsearch.smoketest.MlWithSecurityIT
327324
method: test {yaml=ml/data_frame_analytics_cat_apis/Test cat data frame analytics all jobs with header and column selection}
328325
issue: https://github.com/elastic/elasticsearch/issues/125641

server/src/test/java/org/elasticsearch/index/engine/ThreadPoolMergeSchedulerTests.java

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -390,11 +390,13 @@ public void testMergeSourceWithFollowUpMergesRunSequentially() throws Exception
390390
}).when(mergeSource).merge(any(OneMerge.class));
391391
// trigger run merges on the merge source
392392
threadPoolMergeScheduler.merge(mergeSource, randomFrom(MergeTrigger.values()));
393-
do {
393+
boolean done = false;
394+
while (done == false) {
394395
// let merges run, but wait for the in-progress one to signal it is running
395396
nextMergeSemaphore.acquire();
397+
done = runMergeIdx.get() >= followUpMergeCount;
396398
runMergeSemaphore.release();
397-
} while (runMergeIdx.get() < followUpMergeCount);
399+
}
398400
assertBusy(() -> assertTrue(threadPoolMergeExecutorService.allDone()));
399401
}
400402
}

0 commit comments

Comments
 (0)