Skip to content

Commit ebc35b4

Browse files
authored
[ML] Make the Cohere service Model Id field is required (#136017) (#136097)
1 parent 41d7ca9 commit ebc35b4

File tree

3 files changed

+7
-2
lines changed

3 files changed

+7
-2
lines changed

docs/changelog/136017.yaml

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
pr: 136017
2+
summary: Cohere service Model Id field is required
3+
area: Machine Learning
4+
type: bug
5+
issues: []

x-pack/plugin/inference/src/main/java/org/elasticsearch/xpack/inference/services/cohere/CohereService.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -378,7 +378,7 @@ public static InferenceServiceConfiguration get() {
378378
"The name of the model to use for the inference task."
379379
)
380380
.setLabel("Model ID")
381-
.setRequired(false)
381+
.setRequired(true)
382382
.setSensitive(false)
383383
.setUpdatable(false)
384384
.setType(SettingsConfigurationFieldType.STRING)

x-pack/plugin/inference/src/test/java/org/elasticsearch/xpack/inference/services/cohere/CohereServiceTests.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1556,7 +1556,7 @@ public void testGetConfiguration() throws Exception {
15561556
"model_id": {
15571557
"description": "The name of the model to use for the inference task.",
15581558
"label": "Model ID",
1559-
"required": false,
1559+
"required": true,
15601560
"sensitive": false,
15611561
"updatable": false,
15621562
"type": "str",

0 commit comments

Comments
 (0)