Skip to content

Commit ec66857

Browse files
thecoopthecoop
authored
Remove pre-7.2 token serialization support (#118057)
1 parent 638e5b6 commit ec66857

File tree

6 files changed

+88
-446
lines changed

6 files changed

+88
-446
lines changed

‎server/src/main/java/org/elasticsearch/TransportVersions.java‎

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -54,11 +54,9 @@ static TransportVersion def(int id) {
5454
public static final TransportVersion ZERO = def(0);
5555
public static final TransportVersion V_7_0_0 = def(7_00_00_99);
5656
public static final TransportVersion V_7_0_1 = def(7_00_01_99);
57-
public static final TransportVersion V_7_1_0 = def(7_01_00_99);
5857
public static final TransportVersion V_7_2_0 = def(7_02_00_99);
5958
public static final TransportVersion V_7_2_1 = def(7_02_01_99);
6059
public static final TransportVersion V_7_3_0 = def(7_03_00_99);
61-
public static final TransportVersion V_7_3_2 = def(7_03_02_99);
6260
public static final TransportVersion V_7_4_0 = def(7_04_00_99);
6361
public static final TransportVersion V_7_5_0 = def(7_05_00_99);
6462
public static final TransportVersion V_7_6_0 = def(7_06_00_99);

‎x-pack/plugin/core/src/main/java/org/elasticsearch/xpack/core/security/SecurityFeatureSetUsage.java‎

Lines changed: 4 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -55,10 +55,8 @@ public SecurityFeatureSetUsage(StreamInput in) throws IOException {
5555
realmsUsage = in.readGenericMap();
5656
rolesStoreUsage = in.readGenericMap();
5757
sslUsage = in.readGenericMap();
58-
if (in.getTransportVersion().onOrAfter(TransportVersions.V_7_2_0)) {
59-
tokenServiceUsage = in.readGenericMap();
60-
apiKeyServiceUsage = in.readGenericMap();
61-
}
58+
tokenServiceUsage = in.readGenericMap();
59+
apiKeyServiceUsage = in.readGenericMap();
6260
auditUsage = in.readGenericMap();
6361
ipFilterUsage = in.readGenericMap();
6462
anonymousUsage = in.readGenericMap();
@@ -125,10 +123,8 @@ public void writeTo(StreamOutput out) throws IOException {
125123
out.writeGenericMap(realmsUsage);
126124
out.writeGenericMap(rolesStoreUsage);
127125
out.writeGenericMap(sslUsage);
128-
if (out.getTransportVersion().onOrAfter(TransportVersions.V_7_2_0)) {
129-
out.writeGenericMap(tokenServiceUsage);
130-
out.writeGenericMap(apiKeyServiceUsage);
131-
}
126+
out.writeGenericMap(tokenServiceUsage);
127+
out.writeGenericMap(apiKeyServiceUsage);
132128
out.writeGenericMap(auditUsage);
133129
out.writeGenericMap(ipFilterUsage);
134130
out.writeGenericMap(anonymousUsage);

‎x-pack/plugin/core/src/main/java/org/elasticsearch/xpack/core/security/authc/support/TokensInvalidationResult.java‎

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -59,9 +59,6 @@ public TokensInvalidationResult(StreamInput in) throws IOException {
5959
this.invalidatedTokens = in.readStringCollectionAsList();
6060
this.previouslyInvalidatedTokens = in.readStringCollectionAsList();
6161
this.errors = in.readCollectionAsList(StreamInput::readException);
62-
if (in.getTransportVersion().before(TransportVersions.V_7_2_0)) {
63-
in.readVInt();
64-
}
6562
if (in.getTransportVersion().onOrAfter(TransportVersions.V_8_0_0)) {
6663
this.restStatus = RestStatus.readFrom(in);
6764
}
@@ -111,9 +108,6 @@ public void writeTo(StreamOutput out) throws IOException {
111108
out.writeStringCollection(invalidatedTokens);
112109
out.writeStringCollection(previouslyInvalidatedTokens);
113110
out.writeCollection(errors, StreamOutput::writeException);
114-
if (out.getTransportVersion().before(TransportVersions.V_7_2_0)) {
115-
out.writeVInt(5);
116-
}
117111
if (out.getTransportVersion().onOrAfter(TransportVersions.V_8_0_0)) {
118112
RestStatus.writeTo(out, restStatus);
119113
}

‎x-pack/plugin/security/src/internalClusterTest/java/org/elasticsearch/xpack/security/authc/TokenAuthIntegTests.java‎

Lines changed: 15 additions & 22 deletions
Original file line numberDiff line numberDiff line change
@@ -327,8 +327,8 @@ public void testInvalidateNotValidAccessTokens() throws Exception {
327327
ResponseException.class,
328328
() -> invalidateAccessToken(
329329
tokenService.prependVersionAndEncodeAccessToken(
330-
TransportVersions.V_7_3_2,
331-
tokenService.getRandomTokenBytes(TransportVersions.V_7_3_2, randomBoolean()).v1()
330+
TransportVersions.MINIMUM_COMPATIBLE,
331+
tokenService.getRandomTokenBytes(TransportVersions.MINIMUM_COMPATIBLE, randomBoolean()).v1()
332332
)
333333
)
334334
);
@@ -347,7 +347,7 @@ public void testInvalidateNotValidAccessTokens() throws Exception {
347347
byte[] longerAccessToken = new byte[randomIntBetween(17, 24)];
348348
random().nextBytes(longerAccessToken);
349349
invalidateResponse = invalidateAccessToken(
350-
tokenService.prependVersionAndEncodeAccessToken(TransportVersions.V_7_3_2, longerAccessToken)
350+
tokenService.prependVersionAndEncodeAccessToken(TransportVersions.MINIMUM_COMPATIBLE, longerAccessToken)
351351
);
352352
assertThat(invalidateResponse.invalidated(), equalTo(0));
353353
assertThat(invalidateResponse.previouslyInvalidated(), equalTo(0));
@@ -365,7 +365,7 @@ public void testInvalidateNotValidAccessTokens() throws Exception {
365365
byte[] shorterAccessToken = new byte[randomIntBetween(12, 15)];
366366
random().nextBytes(shorterAccessToken);
367367
invalidateResponse = invalidateAccessToken(
368-
tokenService.prependVersionAndEncodeAccessToken(TransportVersions.V_7_3_2, shorterAccessToken)
368+
tokenService.prependVersionAndEncodeAccessToken(TransportVersions.MINIMUM_COMPATIBLE, shorterAccessToken)
369369
);
370370
assertThat(invalidateResponse.invalidated(), equalTo(0));
371371
assertThat(invalidateResponse.previouslyInvalidated(), equalTo(0));
@@ -394,8 +394,8 @@ public void testInvalidateNotValidAccessTokens() throws Exception {
394394

395395
invalidateResponse = invalidateAccessToken(
396396
tokenService.prependVersionAndEncodeAccessToken(
397-
TransportVersions.V_7_3_2,
398-
tokenService.getRandomTokenBytes(TransportVersions.V_7_3_2, randomBoolean()).v1()
397+
TransportVersions.MINIMUM_COMPATIBLE,
398+
tokenService.getRandomTokenBytes(TransportVersions.MINIMUM_COMPATIBLE, randomBoolean()).v1()
399399
)
400400
);
401401
assertThat(invalidateResponse.invalidated(), equalTo(0));
@@ -420,8 +420,8 @@ public void testInvalidateNotValidRefreshTokens() throws Exception {
420420
ResponseException.class,
421421
() -> invalidateRefreshToken(
422422
TokenService.prependVersionAndEncodeRefreshToken(
423-
TransportVersions.V_7_3_2,
424-
tokenService.getRandomTokenBytes(TransportVersions.V_7_3_2, true).v2()
423+
TransportVersions.MINIMUM_COMPATIBLE,
424+
tokenService.getRandomTokenBytes(TransportVersions.MINIMUM_COMPATIBLE, true).v2()
425425
)
426426
)
427427
);
@@ -441,7 +441,7 @@ public void testInvalidateNotValidRefreshTokens() throws Exception {
441441
byte[] longerRefreshToken = new byte[randomIntBetween(17, 24)];
442442
random().nextBytes(longerRefreshToken);
443443
invalidateResponse = invalidateRefreshToken(
444-
TokenService.prependVersionAndEncodeRefreshToken(TransportVersions.V_7_3_2, longerRefreshToken)
444+
TokenService.prependVersionAndEncodeRefreshToken(TransportVersions.MINIMUM_COMPATIBLE, longerRefreshToken)
445445
);
446446
assertThat(invalidateResponse.invalidated(), equalTo(0));
447447
assertThat(invalidateResponse.previouslyInvalidated(), equalTo(0));
@@ -459,7 +459,7 @@ public void testInvalidateNotValidRefreshTokens() throws Exception {
459459
byte[] shorterRefreshToken = new byte[randomIntBetween(12, 15)];
460460
random().nextBytes(shorterRefreshToken);
461461
invalidateResponse = invalidateRefreshToken(
462-
TokenService.prependVersionAndEncodeRefreshToken(TransportVersions.V_7_3_2, shorterRefreshToken)
462+
TokenService.prependVersionAndEncodeRefreshToken(TransportVersions.MINIMUM_COMPATIBLE, shorterRefreshToken)
463463
);
464464
assertThat(invalidateResponse.invalidated(), equalTo(0));
465465
assertThat(invalidateResponse.previouslyInvalidated(), equalTo(0));
@@ -488,8 +488,8 @@ public void testInvalidateNotValidRefreshTokens() throws Exception {
488488

489489
invalidateResponse = invalidateRefreshToken(
490490
TokenService.prependVersionAndEncodeRefreshToken(
491-
TransportVersions.V_7_3_2,
492-
tokenService.getRandomTokenBytes(TransportVersions.V_7_3_2, true).v2()
491+
TransportVersions.MINIMUM_COMPATIBLE,
492+
tokenService.getRandomTokenBytes(TransportVersions.MINIMUM_COMPATIBLE, true).v2()
493493
)
494494
);
495495
assertThat(invalidateResponse.invalidated(), equalTo(0));
@@ -758,18 +758,11 @@ public void testAuthenticateWithWrongToken() throws Exception {
758758
assertAuthenticateWithToken(response.accessToken(), TEST_USER_NAME);
759759
// Now attempt to authenticate with an invalid access token string
760760
assertUnauthorizedToken(randomAlphaOfLengthBetween(0, 128));
761-
// Now attempt to authenticate with an invalid access token with valid structure (pre 7.2)
761+
// Now attempt to authenticate with an invalid access token with valid structure (after 8.0 pre 8.10)
762762
assertUnauthorizedToken(
763763
tokenService.prependVersionAndEncodeAccessToken(
764-
TransportVersions.V_7_1_0,
765-
tokenService.getRandomTokenBytes(TransportVersions.V_7_1_0, randomBoolean()).v1()
766-
)
767-
);
768-
// Now attempt to authenticate with an invalid access token with valid structure (after 7.2 pre 8.10)
769-
assertUnauthorizedToken(
770-
tokenService.prependVersionAndEncodeAccessToken(
771-
TransportVersions.V_7_4_0,
772-
tokenService.getRandomTokenBytes(TransportVersions.V_7_4_0, randomBoolean()).v1()
764+
TransportVersions.V_8_0_0,
765+
tokenService.getRandomTokenBytes(TransportVersions.V_8_0_0, randomBoolean()).v1()
773766
)
774767
);
775768
// Now attempt to authenticate with an invalid access token with valid structure (current version)

0 commit comments

Comments
 (0)