Remove unused code (#138183)

Author: idegtiarenko

x-pack/plugin/esql/qa/testFixtures/src/main/java/org/elasticsearch/xpack/esql/EsqlTestUtils.java

@@ -324,7 +324,8 @@ public static EsRelation relation() {
     }
 
     public static EsRelation relation(IndexMode mode) {
-        return new EsRelation(EMPTY, new EsIndex(randomAlphaOfLength(8), emptyMap()), mode);
+        var index = new EsIndex(randomAlphaOfLength(8), emptyMap());
+        return new EsRelation(EMPTY, index.name(), mode, index.indexNameWithModes(), List.of());
     }
 
     /**

x-pack/plugin/esql/src/main/java/org/elasticsearch/xpack/esql/plan/logical/EsRelation.java

@@ -12,19 +12,15 @@
 import org.elasticsearch.common.io.stream.StreamOutput;
 import org.elasticsearch.index.IndexMode;
 import org.elasticsearch.xpack.esql.core.expression.Attribute;
-import org.elasticsearch.xpack.esql.core.expression.FieldAttribute;
 import org.elasticsearch.xpack.esql.core.tree.NodeInfo;
 import org.elasticsearch.xpack.esql.core.tree.NodeUtils;
 import org.elasticsearch.xpack.esql.core.tree.Source;
-import org.elasticsearch.xpack.esql.core.type.EsField;
 import org.elasticsearch.xpack.esql.index.EsIndex;
 import org.elasticsearch.xpack.esql.io.stream.PlanStreamInput;
 
 import java.io.IOException;
-import java.util.ArrayList;
 import java.util.List;
 import java.util.Map;
-import java.util.Map.Entry;
 import java.util.Objects;
 import java.util.Set;
 
@@ -40,10 +36,6 @@ public class EsRelation extends LeafPlan {
     private final Map<String, IndexMode> indexNameWithModes;
     private final List<Attribute> attrs;
 
-    public EsRelation(Source source, EsIndex index, IndexMode indexMode) {
-        this(source, index.name(), indexMode, index.indexNameWithModes(), flatten(source, index.mapping()));
-    }
-
     public EsRelation(
         Source source,
         String indexPattern,
@@ -104,35 +96,6 @@ protected NodeInfo<EsRelation> info() {
         return NodeInfo.create(this, EsRelation::new, indexPattern, indexMode, indexNameWithModes, attrs);
     }
 
-    private static List<Attribute> flatten(Source source, Map<String, EsField> mapping) {
-        return flatten(source, mapping, null);
-    }
-
-    private static List<Attribute> flatten(Source source, Map<String, EsField> mapping, FieldAttribute parent) {
-        List<Attribute> list = new ArrayList<>();
-
-        for (Entry<String, EsField> entry : mapping.entrySet()) {
-            String name = entry.getKey();
-            EsField t = entry.getValue();
-
-            if (t != null) {
-                FieldAttribute f = new FieldAttribute(
-                    source,
-                    parent != null ? parent.name() : null,
-                    null,
-                    parent != null ? parent.name() + "." + name : name,
-                    t
-                );
-                list.add(f);
-                // object or nested
-                if (t.getProperties().isEmpty() == false) {
-                    list.addAll(flatten(source, t.getProperties(), f));
-                }
-            }
-        }
-        return list;
-    }
-
     public String indexPattern() {
         return indexPattern;
     }

x-pack/plugin/esql/src/test/java/org/elasticsearch/xpack/esql/optimizer/PhysicalPlanOptimizerTests.java

@@ -164,6 +164,7 @@
 import java.util.Map;
 import java.util.Objects;
 import java.util.Set;
+import java.util.function.Function;
 import java.util.regex.Pattern;
 import java.util.stream.Collectors;
 
@@ -3246,18 +3247,17 @@ public void testProjectAwayColumns() {
         // \_FragmentExec[filter=null, estimatedRowSize=0, reducer=[], fragment=[<>
         // EsRelation[test][some_field1{f}#2, some_field2{f}#3]<>]]
 
-        EsRelation relation = new EsRelation(
+        var esField = List.of(
+            new EsField("some_field1", DataType.KEYWORD, Map.of(), true, EsField.TimeSeriesFieldType.NONE),
+            new EsField("some_field2", DataType.KEYWORD, Map.of(), true, EsField.TimeSeriesFieldType.NONE)
+        );
+        var index = new EsIndex("test", esField.stream().collect(Collectors.toMap(EsField::getName, Function.identity())));
+        var relation = new EsRelation(
             Source.EMPTY,
-            new EsIndex(
-                "test",
-                Map.of(
-                    "some_field1",
-                    new EsField("some_field1", DataType.KEYWORD, Map.of(), true, EsField.TimeSeriesFieldType.NONE),
-                    "some_field2",
-                    new EsField("some_field2", DataType.KEYWORD, Map.of(), true, EsField.TimeSeriesFieldType.NONE)
-                )
-            ),
-            IndexMode.STANDARD
+            index.name(),
+            IndexMode.STANDARD,
+            index.indexNameWithModes(),
+            esField.stream().map(field -> (Attribute) new FieldAttribute(Source.EMPTY, null, null, field.getName(), field)).toList()
         );
         Attribute some_field1 = relation.output().get(0);
         Attribute some_field2 = relation.output().get(1);