use randomValueOtherThanMany

Author: parkertimmins

x-pack/plugin/logsdb/src/test/java/org/elasticsearch/xpack/logsdb/patternedtext/PatternedTextVsMatchOnlyTextTests.java

@@ -258,15 +258,11 @@ private static String randomSeparator() {
     }
 
     private static String randomTimestamp() {
-        ZonedDateTime zonedDateTime;
-        do {
-            long millis = randomMillisUpToYear9999();
-            zonedDateTime = ZonedDateTime.ofInstant(Instant.ofEpochMilli(millis), randomZone());
-
-            // The random millis are below year 10000 in UTC, but if the date is within 1 day of year 10000, the year can be 10000 in the
-            // selected timezone. Since the date formatter cannot handle years greater than 9999, select another date.
-        } while (zonedDateTime.getYear() == 10000);
-
+        // The random millis are below year 10000 in UTC, but if the date is within 1 day of year 10000, the year can be 10000 in the
+        // selected timezone. Since the date formatter cannot handle years greater than 9999, select another date.
+        var zonedDateTime = randomValueOtherThanMany(t -> t.getYear() == 10000, () ->
+            ZonedDateTime.ofInstant(Instant.ofEpochMilli(randomMillisUpToYear9999()), randomZone())
+        );
         DateFormatter formatter = DateFormatter.forPattern(randomDateFormatterPattern()).withLocale(randomLocale(random()));
         return formatter.format(zonedDateTime);
     }