Refactor

Author: elasticsearchmachine

x-pack/plugin/esql/compute/src/main/java/org/elasticsearch/compute/lucene/LuceneTopNSourceOperator.java

@@ -278,14 +278,11 @@ private Page emit() {
         for(int i = 0; i < sortValuesBlockBuilders.length; i++) {
             sortValuesBlockBuilders[i] = blockFactory.newDoubleBlockBuilder(size);
         }
-        DoubleBlock[] sortValuesBlocks = null;
-
         try (
             IntVector.Builder currentSegmentBuilder = blockFactory.newIntVectorFixedBuilder(size);
             IntVector.Builder currentDocsBuilder = blockFactory.newIntVectorFixedBuilder(size);
             DoubleVector.Builder currentScoresBuilder = scoreVectorOrNull(size);
         ) {
-
             int start = offset;
             offset += size;
             List<LeafReaderContext> leafContexts = perShardCollector.shardContext.searcher().getLeafContexts();
@@ -298,15 +295,12 @@ private Page emit() {
                     float score = getScore(topDocs[i]);
                     currentScoresBuilder.appendDouble(score);
                 }
-                // TODO Get the blocks according to the sort types for the sorts to extract - could be different types
-                // Should we do the script field type materialization later? So it's part of loading the field via a script?
-                // We don't reuse the order, but it's similar to how fetching source works.
                 if ((extractSortCount > 0) && topDocs[i] instanceof FieldDoc fieldDoc) {
                     int sortIndex = 0;
                     int extractedSortIndex = 0;
                     for (SortBuilder<?> sortBuilder : sorts) {
                         if (sortBuilder instanceof ScriptSortBuilder) {
-                            Object sortValue = ((FieldDoc) topDocs[i]).fields[sortIndex];
+                            Object sortValue = fieldDoc.fields[sortIndex];
                             if (sortValue == null) {
                                 sortValuesBlockBuilders[extractedSortIndex].appendNull();
                             } else if (sortValue instanceof Number numberSort) {
@@ -337,11 +331,9 @@ private Page emit() {
                 scores = currentScoresBuilder.build().asBlock();
                 page = new Page(size, docBlock, scores);
             }
-            sortValuesBlocks = new DoubleBlock[extractSortCount];
             for(int i = 0; i < extractSortCount; i++) {
-                sortValuesBlocks[i] = sortValuesBlockBuilders[i].build();
+                page = page.appendBlock(sortValuesBlockBuilders[i].build());
             }
-            page = page.appendBlocks(sortValuesBlocks);
         } finally {
             if (page == null) {
                 Releasables.closeExpectNoException(shard, segments, docs, docBlock, scores);