Addressing feedback

Author: jonathan-buttner

x-pack/plugin/core/src/main/java/org/elasticsearch/xpack/core/inference/action/InferenceActionProxy.java

@@ -30,7 +30,7 @@
  */
 public class InferenceActionProxy extends ActionType<InferenceAction.Response> {
     public static final InferenceActionProxy INSTANCE = new InferenceActionProxy();
-    public static final String NAME = "cluster:monitor/xpack/inference";
+    public static final String NAME = "cluster:monitor/xpack/inference/post";
 
     public InferenceActionProxy() {
         super(NAME);
@@ -99,7 +99,6 @@ public boolean isStreaming() {
 
         @Override
         public ActionRequestValidationException validate() {
-            // TODO confirm that we don't need any validation
             return null;
         }
 
@@ -121,7 +120,9 @@ public boolean equals(Object o) {
             return taskType == request.taskType
                 && Objects.equals(inferenceEntityId, request.inferenceEntityId)
                 && Objects.equals(content, request.content)
-                && contentType == request.contentType;
+                && contentType == request.contentType
+                && timeout == request.timeout
+                && stream == request.stream;
         }
 
         @Override

x-pack/plugin/core/src/test/java/org/elasticsearch/xpack/core/security/authz/store/ReservedRolesStoreTests.java

@@ -4140,7 +4140,7 @@ public void testInferenceAdminRole() {
         assertThat(roleDescriptor.getMetadata(), hasEntry("_reserved", true));
 
         Role role = Role.buildFromRoleDescriptor(roleDescriptor, new FieldPermissionsCache(Settings.EMPTY), RESTRICTED_INDICES);
-        assertTrue(role.cluster().check("cluster:monitor/xpack/inference", request, authentication));
+        assertTrue(role.cluster().check("cluster:monitor/xpack/inference/post", request, authentication));
         assertTrue(role.cluster().check("cluster:monitor/xpack/inference/get", request, authentication));
         assertTrue(role.cluster().check("cluster:admin/xpack/inference/put", request, authentication));
         assertTrue(role.cluster().check("cluster:admin/xpack/inference/delete", request, authentication));
@@ -4160,7 +4160,7 @@ public void testInferenceUserRole() {
         assertThat(roleDescriptor.getMetadata(), hasEntry("_reserved", true));
 
         Role role = Role.buildFromRoleDescriptor(roleDescriptor, new FieldPermissionsCache(Settings.EMPTY), RESTRICTED_INDICES);
-        assertTrue(role.cluster().check("cluster:monitor/xpack/inference", request, authentication));
+        assertTrue(role.cluster().check("cluster:monitor/xpack/inference/post", request, authentication));
         assertTrue(role.cluster().check("cluster:monitor/xpack/inference/get", request, authentication));
         assertFalse(role.cluster().check("cluster:admin/xpack/inference/put", request, authentication));
         assertFalse(role.cluster().check("cluster:admin/xpack/inference/delete", request, authentication));

x-pack/plugin/security/qa/operator-privileges-tests/src/javaRestTest/java/org/elasticsearch/xpack/security/operator/Constants.java

@@ -388,7 +388,7 @@ public class Constants {
         "cluster:monitor/xpack/enrich/stats",
         "cluster:monitor/xpack/eql/stats/dist",
         "cluster:monitor/xpack/esql/stats/dist",
-        "cluster:monitor/xpack/inference",
+        "cluster:monitor/xpack/inference/post",
         "cluster:monitor/xpack/inference/get",
         "cluster:monitor/xpack/inference/diagnostics/get",
         "cluster:monitor/xpack/inference/services/get",