Skip to content

Commit ee5d652

Browse files
authored
Increase node up timeout in AbstractLocalClusterFactory (#129639)
In the last two months a lot of tests were converted to use the newer rest test framework. Some tests start 1 node, other start 3 nodes, others even more, the framework runs tests in parallel but it doesn't know how many nodes its tests needs meaning that running 3 tests in parallel, for example, can be very different when they are single node clusters or 3 node clusters etc. During this execution we saw the 3x more CPU load than what we would want to have ideally. Currently there is no good solution for this because if dial down the concurrency we will use the nodes inefficiently, but if we keep the concurrency to where it is we risk longer start up times. Considering that the starting time of elasticsearch is not related to this test, we choose to increase the timeout to reduce the noise.
1 parent 34ccaba commit ee5d652

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

test/test-clusters/src/main/java/org/elasticsearch/test/cluster/local/AbstractLocalClusterFactory.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -73,7 +73,7 @@ public abstract class AbstractLocalClusterFactory<S extends LocalClusterSpec, H
7373
implements
7474
LocalClusterFactory<S, H> {
7575
private static final Logger LOGGER = LogManager.getLogger(AbstractLocalClusterFactory.class);
76-
private static final Duration NODE_UP_TIMEOUT = Duration.ofMinutes(3);
76+
private static final Duration NODE_UP_TIMEOUT = Duration.ofMinutes(6);
7777
private static final Map<Pair<Version, DistributionType>, DistributionDescriptor> TEST_DISTRIBUTIONS = new ConcurrentHashMap<>();
7878
private static final String TESTS_CLUSTER_MODULES_PATH_SYSPROP = "tests.cluster.modules.path";
7979
private static final String TESTS_CLUSTER_PLUGINS_PATH_SYSPROP = "tests.cluster.plugins.path";

0 commit comments

Comments
 (0)