Skip to content

Commit ee92149

Browse files
committed
remove double-counting of inference memory
1 parent 4ffe49c commit ee92149

File tree

1 file changed

+1
-7
lines changed

1 file changed

+1
-7
lines changed

x-pack/plugin/ml/src/main/java/org/elasticsearch/xpack/ml/inference/assignment/TrainedModelAssignmentRebalancer.java

Lines changed: 1 addition & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -298,9 +298,7 @@ private Map<List<String>, List<AssignmentPlan.Node>> createNodesByZoneMap() {
298298
nodes.add(
299299
new AssignmentPlan.Node(
300300
discoveryNode.getId(),
301-
// We subtract native inference memory as the planner expects available memory for
302-
// native inference including current assignments.
303-
getNodeFreeMemoryExcludingPerNodeOverheadAndNativeInference(load),
301+
load.getFreeMemoryExcludingPerNodeOverhead(),
304302
MlProcessors.get(discoveryNode, allocatedProcessorsScale).roundUp()
305303
)
306304
);
@@ -317,10 +315,6 @@ private Map<List<String>, List<AssignmentPlan.Node>> createNodesByZoneMap() {
317315
}));
318316
}
319317

320-
private static long getNodeFreeMemoryExcludingPerNodeOverheadAndNativeInference(NodeLoad load) {
321-
return load.getFreeMemoryExcludingPerNodeOverhead() - load.getAssignedNativeInferenceMemory();
322-
}
323-
324318
private TrainedModelAssignmentMetadata.Builder buildAssignmentsFromPlan(AssignmentPlan assignmentPlan) {
325319
TrainedModelAssignmentMetadata.Builder builder = TrainedModelAssignmentMetadata.Builder.empty();
326320
for (AssignmentPlan.Deployment deployment : assignmentPlan.deployments()) {

0 commit comments

Comments
 (0)