Change rest status for TooManyBucketsException (#95304) (#95328)

not-napoleon · web-flow · commit ee9fdc9f8e28 · 2023-04-18T09:27:42.000-04:00
Resolves #37957 Retrying will not resolve TooManyBucketsException, therefore we should not return a 5xx class error. After some discussion, we decided 400 - Bad Request was the most appropriate choice.
diff --git a/docs/changelog/95304.yaml b/docs/changelog/95304.yaml
@@ -0,0 +1,6 @@
+pr: 95304
+summary: Change rest status for `TooManyBucketsException`
+area: Aggregations
+type: bug
+issues:
+ - 37957
diff --git a/server/src/main/java/org/elasticsearch/search/aggregations/MultiBucketConsumerService.java b/server/src/main/java/org/elasticsearch/search/aggregations/MultiBucketConsumerService.java
@@ -75,7 +75,7 @@ public int getMaxBuckets() {
 
         @Override
         public RestStatus status() {
-            return RestStatus.SERVICE_UNAVAILABLE;
+            return RestStatus.BAD_REQUEST;
         }
 
         @Override

Original file line number	Diff line number	Diff line change
`@@ -75,7 +75,7 @@ public int getMaxBuckets() {`
`75`	`75`
`76`	`76`	`@Override`
`77`	`77`	`public RestStatus status() {`
`78`		`- return RestStatus.SERVICE_UNAVAILABLE;`
	`78`	`+ return RestStatus.BAD_REQUEST;`
`79`	`79`	`}`
`80`	`80`
`81`	`81`	`@Override`