Memoize at point of creation, not point of use

Author: prdoyle

libs/entitlement/src/main/java/org/elasticsearch/entitlement/runtime/policy/PolicyManager.java

@@ -80,7 +80,7 @@ record ModuleEntitlements(
         String componentName,
         Map<Class<? extends Entitlement>, List<Entitlement>> entitlementsByType,
         FileAccessTree fileAccess,
-        String loggerName
+        Logger logger
     ) {
 
         ModuleEntitlements {
@@ -98,10 +98,6 @@ public <E extends Entitlement> Stream<E> getEntitlements(Class<E> entitlementCla
             }
             return entitlements.stream().map(entitlementClass::cast);
         }
-
-        public Logger logger() {
-            return MODULE_LOGGERS.computeIfAbsent(loggerName, LogManager::getLogger);
-        }
     }
 
     private static final ConcurrentHashMap<String, Logger> MODULE_LOGGERS = new ConcurrentHashMap<>();
@@ -579,9 +575,9 @@ private void notEntitled(String message, Class<?> callerClass, ModuleEntitlement
         throw exception;
     }
 
-    private static String getLogger(String componentName, String moduleName) {
+    private static Logger getLogger(String componentName, String moduleName) {
         var loggerSuffix = "." + componentName + "." + ((moduleName == null) ? ALL_UNNAMED : moduleName);
-        return PolicyManager.class.getName() + loggerSuffix;
+        return MODULE_LOGGERS.computeIfAbsent(PolicyManager.class.getName() + loggerSuffix, LogManager::getLogger);
     }
 
     public void checkManageThreadsEntitlement(Class<?> callerClass) {