Skip to content

Commit efaf72d

Browse files
authored
Unmute Categorize VerifierTests and require snapshot on them (#117016) (#117331)
Fixes #116856 Fixes #116857 Fixes #116858
1 parent e0e96a1 commit efaf72d

File tree

2 files changed

+6
-12
lines changed

2 files changed

+6
-12
lines changed

muted-tests.yml

Lines changed: 0 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -359,15 +359,6 @@ tests:
359359
- class: org.elasticsearch.oldrepos.OldRepositoryAccessIT
360360
method: testOldRepoAccess
361361
issue: https://github.com/elastic/elasticsearch/issues/115631
362-
- class: org.elasticsearch.xpack.esql.analysis.VerifierTests
363-
method: testCategorizeNestedGrouping
364-
issue: https://github.com/elastic/elasticsearch/issues/116858
365-
- class: org.elasticsearch.xpack.esql.analysis.VerifierTests
366-
method: testCategorizeSingleGrouping
367-
issue: https://github.com/elastic/elasticsearch/issues/116857
368-
- class: org.elasticsearch.xpack.esql.analysis.VerifierTests
369-
method: testCategorizeWithinAggregations
370-
issue: https://github.com/elastic/elasticsearch/issues/116856
371362

372363
# Examples:
373364
#

x-pack/plugin/esql/src/test/java/org/elasticsearch/xpack/esql/analysis/VerifierTests.java

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1732,7 +1732,8 @@ public void testIntervalAsString() {
17321732
}
17331733

17341734
public void testCategorizeSingleGrouping() {
1735-
assumeTrue("requires snapshot builds", Build.current().isSnapshot());
1735+
assumeTrue("requires Categorize capability", EsqlCapabilities.Cap.CATEGORIZE.isEnabled());
1736+
17361737
query("from test | STATS COUNT(*) BY CATEGORIZE(first_name)");
17371738
query("from test | STATS COUNT(*) BY cat = CATEGORIZE(first_name)");
17381739

@@ -1760,7 +1761,8 @@ public void testCategorizeSingleGrouping() {
17601761
}
17611762

17621763
public void testCategorizeNestedGrouping() {
1763-
assumeTrue("requires snapshot builds", Build.current().isSnapshot());
1764+
assumeTrue("requires Categorize capability", EsqlCapabilities.Cap.CATEGORIZE.isEnabled());
1765+
17641766
query("from test | STATS COUNT(*) BY CATEGORIZE(LENGTH(first_name)::string)");
17651767

17661768
assertEquals(
@@ -1774,7 +1776,8 @@ public void testCategorizeNestedGrouping() {
17741776
}
17751777

17761778
public void testCategorizeWithinAggregations() {
1777-
assumeTrue("requires snapshot builds", Build.current().isSnapshot());
1779+
assumeTrue("requires Categorize capability", EsqlCapabilities.Cap.CATEGORIZE.isEnabled());
1780+
17781781
query("from test | STATS MV_COUNT(cat), COUNT(*) BY cat = CATEGORIZE(first_name)");
17791782

17801783
assertEquals(

0 commit comments

Comments
 (0)