Test+todo for nicer error message

jan-elastic · jan-elastic · commit f00522af4a22 · 2025-02-06T12:55:19.000+01:00
diff --git a/x-pack/plugin/esql/src/test/java/org/elasticsearch/xpack/esql/analysis/VerifierTests.java b/x-pack/plugin/esql/src/test/java/org/elasticsearch/xpack/esql/analysis/VerifierTests.java
@@ -2021,6 +2021,8 @@ public void testChangePoint() {
         var airports = AnalyzerTestUtils.analyzer(loadMapping("mapping-airports.json", "airports"));
         assertEquals("1:30: Unknown column [blahblah]", error("FROM airports | CHANGE_POINT blahblah ON scalerank", airports));
         assertEquals("1:43: Unknown column [blahblah]", error("FROM airports | CHANGE_POINT scalerank ON blahblah", airports));
+        // TODO: nicer error message for missing default column "@timestamp"
+        assertEquals("1:17: Unknown column [@timestamp]", error("FROM airports | CHANGE_POINT scalerank", airports));
     }
 
     public void testChangePoint_keySortable() {

Original file line number	Diff line number	Diff line change
`@@ -2021,6 +2021,8 @@ public void testChangePoint() {`
`2021`	`2021`	`var airports = AnalyzerTestUtils.analyzer(loadMapping("mapping-airports.json", "airports"));`
`2022`	`2022`	`assertEquals("1:30: Unknown column [blahblah]", error("FROM airports \| CHANGE_POINT blahblah ON scalerank", airports));`
`2023`	`2023`	`assertEquals("1:43: Unknown column [blahblah]", error("FROM airports \| CHANGE_POINT scalerank ON blahblah", airports));`
	`2024`	`+ // TODO: nicer error message for missing default column "@timestamp"`
	`2025`	`+ assertEquals("1:17: Unknown column [@timestamp]", error("FROM airports \| CHANGE_POINT scalerank", airports));`
`2024`	`2026`	`}`
`2025`	`2027`
`2026`	`2028`	`public void testChangePoint_keySortable() {`