Cleanup based on PR discussion

kderusso · kderusso · commit f0258301c21f · 2025-06-25T16:53:53.000-04:00
diff --git a/x-pack/plugin/inference/src/main/java/org/elasticsearch/xpack/inference/mapper/SemanticTextFieldMapper.java b/x-pack/plugin/inference/src/main/java/org/elasticsearch/xpack/inference/mapper/SemanticTextFieldMapper.java
@@ -291,9 +291,9 @@ private boolean indexOptionsSerializerCheck(boolean includeDefaults, boolean isC
                     ? modelSettings.get()
                     : modelRegistry.getMinimalServiceSettings(inferenceId.get());
                 return defaultIndexOptions(indexVersionCreated, resolvedModelSettings) != null;
-            } else {
-                return isConfigured;
             }
+
+            return includeDefaults || isConfigured;
         }
 
         public Builder setInferenceId(String id) {

Original file line number	Diff line number	Diff line change
`@@ -291,9 +291,9 @@ private boolean indexOptionsSerializerCheck(boolean includeDefaults, boolean isC`
`291`	`291`	`? modelSettings.get()`
`292`	`292`	`: modelRegistry.getMinimalServiceSettings(inferenceId.get());`
`293`	`293`	`return defaultIndexOptions(indexVersionCreated, resolvedModelSettings) != null;`
`294`		`- } else {`
`295`		`- return isConfigured;`
`296`	`294`	`}`
	`295`	`+`
	`296`	`+ return includeDefaults \|\| isConfigured;`
`297`	`297`	`}`
`298`	`298`
`299`	`299`	`public Builder setInferenceId(String id) {`