Skip to content

Commit f04516c

Browse files
committed
Fix old syntax in comments.
1 parent e36156c commit f04516c

File tree

1 file changed

+2
-0
lines changed

1 file changed

+2
-0
lines changed

x-pack/plugin/esql/src/main/java/org/elasticsearch/xpack/esql/parser/LogicalPlanBuilder.java

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -843,6 +843,8 @@ private Completion applyCompletionOptions(Completion completion, EsqlBaseParser.
843843
);
844844
}
845845
} else {
846+
// This is an anti-pattern to have a mandatory named params for inference_id but it will be optional in the future when we have a default LLM.
847+
// It is better to keep inference_id as a named parameter and relax the syntax when it will become optional than completely change the syntax.
846848
throw new ParsingException(source(ctx), "Missing mandatory option [{}] in COMPLETION", Completion.INFERENCE_ID_OPTION_NAME);
847849
}
848850

0 commit comments

Comments
 (0)