Skip to content

Commit f193a4d

Browse files
committed
Add wrappings to capture more errors
1 parent bbf6dca commit f193a4d

File tree

2 files changed

+9
-6
lines changed

2 files changed

+9
-6
lines changed

x-pack/plugin/esql/src/main/java/org/elasticsearch/xpack/esql/execution/PlanExecutor.java

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -77,15 +77,17 @@ public void esql(
7777
);
7878
QueryMetric clientId = QueryMetric.fromString("rest");
7979
metrics.total(clientId);
80-
session.execute(request, executionInfo, planRunner, wrap(x -> {
80+
81+
ActionListener<Result> executeListener = wrap(x -> {
8182
planningMetricsManager.publish(planningMetrics, true);
8283
listener.onResponse(x);
8384
}, ex -> {
8485
// TODO when we decide if we will differentiate Kibana from REST, this String value will likely come from the request
8586
metrics.failed(clientId);
8687
planningMetricsManager.publish(planningMetrics, false);
8788
listener.onFailure(ex);
88-
}));
89+
});
90+
ActionListener.run(executeListener, l -> session.execute(request, executionInfo, planRunner, l));
8991
}
9092

9193
public IndexResolver indexResolver() {

x-pack/plugin/esql/src/main/java/org/elasticsearch/xpack/esql/plugin/TransportEsqlQueryAction.java

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -195,12 +195,12 @@ private void innerExecute(Task task, EsqlQueryRequest request, ActionListener<Es
195195
executionInfo,
196196
remoteClusterService,
197197
planRunner,
198-
ActionListener.wrap((result) -> {
198+
ActionListener.wrap(result -> {
199199
recordCCSTelemetry(task, executionInfo, request, null);
200200
listener.onResponse(toResponse(task, request, configuration, result));
201-
}, (e) -> {
202-
recordCCSTelemetry(task, executionInfo, request, e);
203-
listener.onFailure(e);
201+
}, ex -> {
202+
recordCCSTelemetry(task, executionInfo, request, ex);
203+
listener.onFailure(ex);
204204
})
205205
);
206206

@@ -236,6 +236,7 @@ private void recordCCSTelemetry(Task task, EsqlExecutionInfo executionInfo, Esql
236236
count.getAndIncrement();
237237
}
238238
});
239+
assert count.get() > 0 : "Got cross-cluster search telemetry without any remote clusters";
239240
usageBuilder.setRemotesCount(count.get());
240241
usageService.getEsqlUsageHolder().updateUsage(usageBuilder.build());
241242
}

0 commit comments

Comments
 (0)