No logging for impossible case

Author: DaveCTurner

server/src/main/java/org/elasticsearch/snapshots/SnapshotShardsService.java

@@ -939,16 +939,14 @@ private void runCheck() {
                     if (clusterStateSnapshotEntry != null) {
                         for (final var shardId : snapshotShards.getValue()) {
                             final var clusterStateShardStatus = clusterStateSnapshotEntry.shards().get(shardId);
-                            if (clusterStateShardStatus == null) {
-                                CONSISTENCY_CHECKER_LOGGER.debug("shard [{}] in snapshot [{}] unexpectedly not found", shardId, snapshot);
-                            } else if (clusterStateShardStatus.state().completed() == false) {
+                            if (clusterStateShardStatus != null && clusterStateShardStatus.state().completed() == false) {
                                 CONSISTENCY_CHECKER_LOGGER.debug(
                                     "shard [{}] in snapshot [{}] unexpectedly still in state [{}] after notifying master",
                                     shardId,
                                     snapshot,
                                     clusterStateShardStatus
                                 );
-                            } // else shard is marked complete as expected
+                            } // else shard is marked complete as expected (the null case should be impossible)
                         }
                     } // else snapshot already completed & removed from cluster state
                 }