Fix restricted API

Author: lukewhiting

x-pack/plugin/core/src/main/java/org/elasticsearch/xpack/core/scheduler/Cron.java

@@ -8,6 +8,7 @@
 
 import org.elasticsearch.ElasticsearchParseException;
 import org.elasticsearch.common.time.DateFormatter;
+import org.elasticsearch.core.SuppressForbidden;
 import org.elasticsearch.xcontent.ToXContentFragment;
 import org.elasticsearch.xcontent.XContentBuilder;
 
@@ -301,6 +302,7 @@ public void setTimeZone(TimeZone timeZone) {
      *             a time that is previous to the given time)
      * @return the next valid time (since the epoch)
      */
+    @SuppressForbidden(reason = "In this case, the DST ambiguity of the atZone method is desired, understood and tested")
     public long getNextValidTimeAfter(final long time) {
 
         LocalDateTime afterTimeLdt = LocalDateTime.ofInstant(java.time.Instant.ofEpochMilli(time), timeZone.toZoneId()).plusSeconds(1);

x-pack/plugin/core/src/main/java/org/elasticsearch/xpack/core/scheduler/LocalDateTimeLegacyWrapper.java

@@ -117,23 +117,23 @@ public void plusMonths(long months) {
     }
 
     public void plusWeeks(long weeks) {
-        ldt =  ldt.plusWeeks(weeks);
+        ldt = ldt.plusWeeks(weeks);
     }
 
     public void plusDays(long days) {
-        ldt =  ldt.plusDays(days);
+        ldt = ldt.plusDays(days);
     }
 
     public void plusHours(long hours) {
-        ldt =  ldt.plusHours(hours);
+        ldt = ldt.plusHours(hours);
     }
 
     public void plusMinutes(long minutes) {
-        ldt =  ldt.plusMinutes(minutes);
+        ldt = ldt.plusMinutes(minutes);
     }
 
     public void plusSeconds(long seconds) {
-        ldt =  ldt.plusSeconds(seconds);
+        ldt = ldt.plusSeconds(seconds);
     }
 
     public boolean isAfter(ChronoLocalDateTime<?> other) {