Skip to content

Commit f4031c1

Browse files
authored
[ES|QL] Support for First/Last (#137408) (#138390)
- Skip vector optimization for block arguments when grouping, to prevent grouping aggs from executing the no-op path. - This path will be enabled back once an actual implementation is in place.
1 parent a2b0913 commit f4031c1

13 files changed

+49
-581
lines changed

x-pack/plugin/esql/compute/gen/src/main/java/org/elasticsearch/compute/gen/GroupingAggregatorImplementer.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -335,7 +335,7 @@ private MethodSpec prepareProcessRawInputPage() {
335335
+ aggParams.stream().map(arg -> arg.blockName()).collect(joining(", "))
336336
+ ")";
337337

338-
if (allArgumentsSupportVectors) {
338+
if (allArgumentsSupportVectors && hasOnlyBlockArguments == false) {
339339

340340
for (Argument a : aggParams) {
341341
builder.addStatement(

x-pack/plugin/esql/compute/src/main/generated/org/elasticsearch/compute/aggregation/AllFirstBytesRefByTimestampGroupingAggregatorFunction.java

Lines changed: 4 additions & 53 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

x-pack/plugin/esql/compute/src/main/generated/org/elasticsearch/compute/aggregation/AllFirstDoubleByTimestampGroupingAggregatorFunction.java

Lines changed: 4 additions & 53 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

x-pack/plugin/esql/compute/src/main/generated/org/elasticsearch/compute/aggregation/AllFirstFloatByTimestampGroupingAggregatorFunction.java

Lines changed: 4 additions & 53 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

x-pack/plugin/esql/compute/src/main/generated/org/elasticsearch/compute/aggregation/AllFirstIntByTimestampGroupingAggregatorFunction.java

Lines changed: 4 additions & 52 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)