lucene_snapshot: Fix constructor chaining in LegacyBM25Similarity

Author: elasticsearchmachine

server/src/main/java/org/elasticsearch/lucene/similarity/LegacyBM25Similarity.java

@@ -46,11 +46,6 @@ public LegacyBM25Similarity() {
         this(new BM25Similarity());
     }
 
-    private LegacyBM25Similarity(BM25Similarity bm25Similarity) {
-        super(bm25Similarity.getDiscountOverlaps());
-        this.bm25Similarity = bm25Similarity;
-    }
-
     /**
      * BM25 with the supplied parameter values.
      * @param k1 Controls non-linear term frequency normalization (saturation).
@@ -59,7 +54,12 @@ private LegacyBM25Similarity(BM25Similarity bm25Similarity) {
      *         not within the range {@code [0..1]}
      */
     public LegacyBM25Similarity(float k1, float b, boolean discountOverlaps) {
-        this.bm25Similarity = new BM25Similarity(k1, b, discountOverlaps);
+        this(new BM25Similarity(k1, b, discountOverlaps));
+    }
+
+    private LegacyBM25Similarity(BM25Similarity bm25Similarity) {
+        super(bm25Similarity.getDiscountOverlaps());
+        this.bm25Similarity = bm25Similarity;
     }
 
     @Override